Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: src/stub-cache.h

Issue 430783002: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Port Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_STUB_CACHE_H_ 5 #ifndef V8_STUB_CACHE_H_
6 #define V8_STUB_CACHE_H_ 6 #define V8_STUB_CACHE_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 554
555 class NamedStoreHandlerCompiler : public PropertyHandlerCompiler { 555 class NamedStoreHandlerCompiler : public PropertyHandlerCompiler {
556 public: 556 public:
557 explicit NamedStoreHandlerCompiler(Isolate* isolate, Handle<HeapType> type, 557 explicit NamedStoreHandlerCompiler(Isolate* isolate, Handle<HeapType> type,
558 Handle<JSObject> holder) 558 Handle<JSObject> holder)
559 : PropertyHandlerCompiler(isolate, Code::STORE_IC, type, holder, 559 : PropertyHandlerCompiler(isolate, Code::STORE_IC, type, holder,
560 kCacheOnReceiver) {} 560 kCacheOnReceiver) {}
561 561
562 virtual ~NamedStoreHandlerCompiler() {} 562 virtual ~NamedStoreHandlerCompiler() {}
563 563
564 Handle<Code> CompileStoreTransition(LookupResult* lookup, 564 Handle<Code> CompileStoreTransition(Handle<Map> transition,
565 Handle<Map> transition,
566 Handle<Name> name); 565 Handle<Name> name);
567
568 Handle<Code> CompileStoreField(LookupResult* lookup, Handle<Name> name); 566 Handle<Code> CompileStoreField(LookupResult* lookup, Handle<Name> name);
569
570 Handle<Code> CompileStoreArrayLength(LookupResult* lookup, Handle<Name> name);
571
572 Handle<Code> CompileStoreCallback(Handle<JSObject> object, Handle<Name> name, 567 Handle<Code> CompileStoreCallback(Handle<JSObject> object, Handle<Name> name,
573 Handle<ExecutableAccessorInfo> callback); 568 Handle<ExecutableAccessorInfo> callback);
574
575 Handle<Code> CompileStoreCallback(Handle<JSObject> object, Handle<Name> name, 569 Handle<Code> CompileStoreCallback(Handle<JSObject> object, Handle<Name> name,
576 const CallOptimization& call_optimization); 570 const CallOptimization& call_optimization);
577
578 Handle<Code> CompileStoreViaSetter(Handle<JSObject> object, Handle<Name> name, 571 Handle<Code> CompileStoreViaSetter(Handle<JSObject> object, Handle<Name> name,
579 Handle<JSFunction> setter); 572 Handle<JSFunction> setter);
580
581 Handle<Code> CompileStoreInterceptor(Handle<Name> name); 573 Handle<Code> CompileStoreInterceptor(Handle<Name> name);
582 574
583
584 static void GenerateStoreViaSetter(MacroAssembler* masm, 575 static void GenerateStoreViaSetter(MacroAssembler* masm,
585 Handle<HeapType> type, Register receiver, 576 Handle<HeapType> type, Register receiver,
586 Handle<JSFunction> setter); 577 Handle<JSFunction> setter);
587 578
588 static void GenerateStoreViaSetterForDeopt(MacroAssembler* masm) { 579 static void GenerateStoreViaSetterForDeopt(MacroAssembler* masm) {
589 GenerateStoreViaSetter(masm, Handle<HeapType>::null(), no_reg, 580 GenerateStoreViaSetter(masm, Handle<HeapType>::null(), no_reg,
590 Handle<JSFunction>()); 581 Handle<JSFunction>());
591 } 582 }
592 583
593 protected: 584 protected:
594 virtual Register FrontendHeader(Register object_reg, Handle<Name> name, 585 virtual Register FrontendHeader(Register object_reg, Handle<Name> name,
595 Label* miss); 586 Label* miss);
596 587
597 virtual void FrontendFooter(Handle<Name> name, Label* miss); 588 virtual void FrontendFooter(Handle<Name> name, Label* miss);
598 void GenerateRestoreName(MacroAssembler* masm, Label* label, 589 void GenerateRestoreName(Label* label, Handle<Name> name);
599 Handle<Name> name);
600 590
601 private: 591 private:
602 void GenerateStoreArrayLength(); 592 void GenerateNegativeHolderLookup(Register holder_reg, Handle<Name> name,
603
604 void GenerateNegativeHolderLookup(MacroAssembler* masm,
605 Handle<JSObject> holder,
606 Register holder_reg,
607 Handle<Name> name,
608 Label* miss); 593 Label* miss);
609 594
610 void GenerateStoreTransition(MacroAssembler* masm, 595 void GenerateStoreTransition(Handle<Map> transition, Handle<Name> name,
611 LookupResult* lookup, 596 Register receiver_reg, Register name_reg,
612 Handle<Map> transition, 597 Register value_reg, Register scratch1,
613 Handle<Name> name, 598 Register scratch2, Register scratch3,
614 Register receiver_reg, 599 Label* miss_label, Label* slow);
615 Register name_reg,
616 Register value_reg,
617 Register scratch1,
618 Register scratch2,
619 Register scratch3,
620 Label* miss_label,
621 Label* slow);
622 600
623 void GenerateStoreField(MacroAssembler* masm, 601 void GenerateStoreField(Handle<JSObject> object, LookupResult* lookup,
624 Handle<JSObject> object, 602 Register receiver_reg, Register name_reg,
625 LookupResult* lookup, 603 Register value_reg, Register scratch1,
626 Register receiver_reg, 604 Register scratch2, Label* miss_label);
627 Register name_reg,
628 Register value_reg,
629 Register scratch1,
630 Register scratch2,
631 Label* miss_label);
632 605
633 static Builtins::Name SlowBuiltin(Code::Kind kind) { 606 static Builtins::Name SlowBuiltin(Code::Kind kind) {
634 switch (kind) { 607 switch (kind) {
635 case Code::STORE_IC: return Builtins::kStoreIC_Slow; 608 case Code::STORE_IC: return Builtins::kStoreIC_Slow;
636 case Code::KEYED_STORE_IC: return Builtins::kKeyedStoreIC_Slow; 609 case Code::KEYED_STORE_IC: return Builtins::kKeyedStoreIC_Slow;
637 default: UNREACHABLE(); 610 default: UNREACHABLE();
638 } 611 }
639 return Builtins::kStoreIC_Slow; 612 return Builtins::kStoreIC_Slow;
640 } 613 }
641 614
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
713 Handle<JSFunction> constant_function_; 686 Handle<JSFunction> constant_function_;
714 bool is_simple_api_call_; 687 bool is_simple_api_call_;
715 Handle<FunctionTemplateInfo> expected_receiver_type_; 688 Handle<FunctionTemplateInfo> expected_receiver_type_;
716 Handle<CallHandlerInfo> api_call_info_; 689 Handle<CallHandlerInfo> api_call_info_;
717 }; 690 };
718 691
719 692
720 } } // namespace v8::internal 693 } } // namespace v8::internal
721 694
722 #endif // V8_STUB_CACHE_H_ 695 #endif // V8_STUB_CACHE_H_
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698