Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: src/ic.cc

Issue 430783002: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Port Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic.h ('k') | src/stub-cache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index 1a8366dfeca114a74b8c2c361252908a2062922f..7a6e2206c429811b891fc188a10859bb0eb50a5b 100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -1404,7 +1404,7 @@ Handle<Code> StoreIC::CompileHandler(LookupResult* lookup,
PropertyDetails details = lookup->GetPropertyDetails();
if (details.type() != CALLBACKS && details.attributes() == NONE) {
- return compiler.CompileStoreTransition(lookup, transition, name);
+ return compiler.CompileStoreTransition(transition, name);
}
} else {
switch (lookup->type()) {
@@ -2036,30 +2036,6 @@ RUNTIME_FUNCTION(StoreIC_MissFromStubFailure) {
}
-RUNTIME_FUNCTION(StoreIC_ArrayLength) {
- TimerEventScope<TimerEventIcMiss> timer(isolate);
- HandleScope scope(isolate);
-
- ASSERT(args.length() == 2);
- Handle<JSArray> receiver = args.at<JSArray>(0);
- Handle<Object> len = args.at<Object>(1);
-
- // The generated code should filter out non-Smis before we get here.
- ASSERT(len->IsSmi());
-
-#ifdef DEBUG
- // The length property has to be a writable callback property.
- LookupResult debug_lookup(isolate);
- receiver->LookupOwn(isolate->factory()->length_string(), &debug_lookup);
- ASSERT(debug_lookup.IsPropertyCallbacks() && !debug_lookup.IsReadOnly());
-#endif
-
- RETURN_FAILURE_ON_EXCEPTION(
- isolate, JSArray::SetElementsLength(receiver, len));
- return *len;
-}
-
-
// Extend storage is called in a store inline cache when
// it is necessary to extend the properties array of a
// JSObject.
« no previous file with comments | « src/ic.h ('k') | src/stub-cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698