Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 430603002: Clang roll 209387:214024 (take 2) (Closed)

Created:
6 years, 4 months ago by hans
Modified:
6 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Clang roll 209387:214024 (take 2) - The previous attempt failed due to crashing layout tests (fast/text-autosize). That was fixed in Blink r179171. - This roll seems to cause a slight binary size increase, perhaps related to changed inlining behaviour. On Linux this is offset by the switch to Clang just having saved megs of binary size. On Mac this is unfortunate, but since we haven't rolled in a long time, we decided not to consider it a blocker. - Note: this version adds optimizations based on exploiting that references must refer to valid objects, and so if 'foo' is a reference, checks such as "if (&foo == NULL)" can be optimized away. BUG=381489 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/clang/blink_gc_plugin/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/update.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
hans
Just waiting for a Blink roll now. Previous Clang roll attempt: https://codereview.chromium.org/426703002 The tools/whitespace.txt change ...
6 years, 4 months ago (2014-07-29 21:55:37 UTC) #1
Nico
lgtm
6 years, 4 months ago (2014-07-29 22:03:07 UTC) #2
hans
The CQ bit was checked by hans@chromium.org
6 years, 4 months ago (2014-07-30 13:47:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/430603002/1
6 years, 4 months ago (2014-07-30 13:47:57 UTC) #4
hans
6 years, 4 months ago (2014-07-30 16:23:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r286532 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698