Clang roll 209387:214024

Clang roll 209387:214024

BUG=381489
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286068

[hans, 2014-07-28 20:22:46]

Tryjobs look good.

linux_asan and linux_chromeos_asan failures mathces those on the whitespace
change: https://codereview.chromium.org/405473002

The only missing results are from mac_asan_64, which looks perpetually broken :(
I replied to the tryjob error email, but maybe there's a better way to ping
troopers about it.

[Nico, 2014-07-28 20:26:39]

lgtm, what can go wrong :-)

[hans, 2014-07-28 20:43:38]

iannucci: Can I keep the tools/whitespace.txt in when committing this, or is
there some other way to make sure the CQ trybots and subsequent buildbots don't
skip the compile step?

[iannucci, 2014-07-28 20:44:49]

On 2014/07/28 20:43:38, hans wrote:
> iannucci: Can I keep the tools/whitespace.txt in when committing this, or is
> there some other way to make sure the CQ trybots and subsequent buildbots
don't
> skip the compile step?

I think sky@ made the bots explicitly ignore the whitespace.txt file.

[hans, 2014-07-28 20:46:22]

On 2014/07/28 20:44:49, iannucci wrote:
> On 2014/07/28 20:43:38, hans wrote:
> > iannucci: Can I keep the tools/whitespace.txt in when committing this, or is
> > there some other way to make sure the CQ trybots and subsequent buildbots
> don't
> > skip the compile step?
> 
> I think sky@ made the bots explicitly ignore the whitespace.txt file.

sky: ^^^

[sky, 2014-07-28 20:51:45]

On 2014/07/28 20:46:22, hans wrote:
> On 2014/07/28 20:44:49, iannucci wrote:
> > On 2014/07/28 20:43:38, hans wrote:
> > > iannucci: Can I keep the tools/whitespace.txt in when committing this, or
is
> > > there some other way to make sure the CQ trybots and subsequent buildbots
> > don't
> > > skip the compile step?
> > 
> > I think sky@ made the bots explicitly ignore the whitespace.txt file.
> 
> sky: ^^^

It's more than I made them special case it. By that I mean if you change
tools/whitespace.txt then we won't attempt to early out on compile, which is
what you want here until I fix 398118.

[hans, 2014-07-28 20:52:48]

On 2014/07/28 20:51:45, sky wrote:
> On 2014/07/28 20:46:22, hans wrote:
> > On 2014/07/28 20:44:49, iannucci wrote:
> > > On 2014/07/28 20:43:38, hans wrote:
> > > > iannucci: Can I keep the tools/whitespace.txt in when committing this,
or
> is
> > > > there some other way to make sure the CQ trybots and subsequent
buildbots
> > > don't
> > > > skip the compile step?
> > > 
> > > I think sky@ made the bots explicitly ignore the whitespace.txt file.
> > 
> > sky: ^^^
> 
> It's more than I made them special case it. By that I mean if you change
> tools/whitespace.txt then we won't attempt to early out on compile, which is
> what you want here until I fix 398118.

Just to double check: does that mean it's OK to commit the file?

[sky, 2014-07-28 20:53:42]

Assuming it passed the try runs (or you're ok with the ones that are
failing now), yes.

On Mon, Jul 28, 2014 at 1:52 PM,  <hans@chromium.org> wrote:
> On 2014/07/28 20:51:45, sky wrote:
>>
>> On 2014/07/28 20:46:22, hans wrote:
>> > On 2014/07/28 20:44:49, iannucci wrote:
>> > > On 2014/07/28 20:43:38, hans wrote:
>> > > > iannucci: Can I keep the tools/whitespace.txt in when committing
>> > > > this,
>
> or
>>
>> is
>> > > > there some other way to make sure the CQ trybots and subsequent
>
> buildbots
>>
>> > > don't
>> > > > skip the compile step?
>> > >
>> > > I think sky@ made the bots explicitly ignore the whitespace.txt file.
>> >
>> > sky: ^^^
>
>
>> It's more than I made them special case it. By that I mean if you change
>> tools/whitespace.txt then we won't attempt to early out on compile, which
>> is
>> what you want here until I fix 398118.
>
>
> Just to double check: does that mean it's OK to commit the file?
>
> https://codereview.chromium.org/426703002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hans, 2014-07-28 20:58:00]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2014-07-28 20:59:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hans@chromium.org/426703002/2

[commit-bot: I haz the power, 2014-07-29 01:19:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-07-29 03:02:39]

Change committed as 286068

[alancutter (OOO until 2018), 2014-07-29 09:50:58]

On 2014/07/29 03:02:39, I haz the power (commit-bot) wrote:
> Change committed as 286068

A revert of this CL has been created in
https://codereview.chromium.org/427763002/ by alancutter@chromium.org.

The reason for reverting is:
Clang roll caused release build of Blink test runner to start crashing on
the following layout tests:
fast/text-autosizing/constrained-floats.html
fast/text-autosizing/form-controls-autosizing-button-input-elements.html
fast/text-autosizing/form-controls-autosizing-fieldset-element.html
fast/text-autosizing/form-controls-autosizing-select-element.html

https://code.google.com/p/chromium/issues/detail?id=398348

[Nico, 2014-07-29 13:22:51]

Link to bot?
On Jul 29, 2014 2:50 AM, <alancutter@chromium.org> wrote:

> On 2014/07/29 03:02:39, I haz the power (commit-bot) wrote:
>
>> Change committed as 286068
>>
>
> A revert of this CL has been created in
> https://codereview.chromium.org/427763002/ by alancutter@chromium.org.
>
> The reason for reverting is:
> Clang roll caused release build of Blink test runner to start crashing on
> the following layout tests:
> fast/text-autosizing/constrained-floats.html
> fast/text-autosizing/form-controls-autosizing-button-input-elements.html
> fast/text-autosizing/form-controls-autosizing-fieldset-element.html
> fast/text-autosizing/form-controls-autosizing-select-element.html
>
> https://code.google.com/p/chromium/issues/detail?id=398348
>
>
> https://codereview.chromium.org/426703002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.