Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 420413003: Add a couple of files to the exclusion list (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add a couple of files to the exclusion list These feed into the build system so that they need to trigger a recompile. This isn't ideal, but good enough until I get more general diff'ing in place. BUG=398118 TEST=none R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286096

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2 more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M testing/buildbot/chromium_trybot.json View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
6 years, 4 months ago (2014-07-28 21:31:46 UTC) #1
Nico
lgtm, thanks! Two more files below: https://codereview.chromium.org/420413003/diff/1/testing/buildbot/chromium_trybot.json File testing/buildbot/chromium_trybot.json (right): https://codereview.chromium.org/420413003/diff/1/testing/buildbot/chromium_trybot.json#newcode199 testing/buildbot/chromium_trybot.json:199: "build/linux/sysroot_ld_path.sh", build/compiler_version.py too ...
6 years, 4 months ago (2014-07-28 21:34:47 UTC) #2
sky
Updated.
6 years, 4 months ago (2014-07-28 21:38:19 UTC) #3
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-07-28 21:38:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/420413003/20001
6 years, 4 months ago (2014-07-28 21:39:36 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 04:32:53 UTC) #6
Message was sent while issue was closed.
Change committed as 286096

Powered by Google App Engine
This is Rietveld 408576698