Page action extension icons should handle tap events

Page action extension icons should handle tap events

Handle ui::ET_GESTURE_TAP events in PageImageActionView
by showing the extension popup (the same action
taken on a mouse click). This achieves consistency
between touch and mouse input.

BUG=399748
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287780

[tdanderson, 2014-08-01 21:49:19]

Scott, can you please take a look? I'm not sure whether or not you'd like a test
for this; no tests for either touch or mouse currently exist for this extension
icon type.

[sky, 2014-08-04 17:36:54]

LGTM

https://codereview.chromium.org/430093003/diff/1/chrome/browser/ui/views/loca...
File chrome/browser/ui/views/location_bar/page_action_image_view.h (right):

https://codereview.chromium.org/430093003/diff/1/chrome/browser/ui/views/loca...
chrome/browser/ui/views/location_bar/page_action_image_view.h:38: static const
char kViewClassName[];
nit: there isn't a need to make this public unless an external class needs it.

[tdanderson, 2014-08-05 15:32:32]

https://codereview.chromium.org/430093003/diff/1/chrome/browser/ui/views/loca...
File chrome/browser/ui/views/location_bar/page_action_image_view.h (right):

https://codereview.chromium.org/430093003/diff/1/chrome/browser/ui/views/loca...
chrome/browser/ui/views/location_bar/page_action_image_view.h:38: static const
char kViewClassName[];
On 2014/08/04 17:36:54, sky wrote:
> nit: there isn't a need to make this public unless an external class needs it.

Done.

[tdanderson, 2014-08-05 15:32:35]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2014-08-05 15:34:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/430093003/20001

[commit-bot: I haz the power, 2014-08-05 18:59:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42650)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

[commit-bot: I haz the power, 2014-08-05 19:13:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 19:13:28]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42717)

[tdanderson, 2014-08-05 19:14:46]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2014-08-05 19:15:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/430093003/20001

[commit-bot: I haz the power, 2014-08-05 23:11:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42860)

[commit-bot: I haz the power, 2014-08-05 23:38:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 23:38:59]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42919)

[tdanderson, 2014-08-06 15:50:31]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2014-08-06 15:51:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/430093003/20001

[commit-bot: I haz the power, 2014-08-06 16:34:05]

Change committed as 287780