Page action extension icons should handle tap events

chrome/browser/ui/views/location_bar/page_action_image_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_PAGE_ACTION_IMAGE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_PAGE_ACTION_IMAGE_VIEW_H_
 
 #include <map>
 #include <string>
 
@@ skipping 17 matching lines @@
 }
 
 // PageActionImageView is used by the LocationBarView to display the icon for a
 // given PageAction and notify the extension when the icon is clicked.
 class PageActionImageView : public views::ImageView,
                             public ExtensionContextMenuModel::PopupDelegate,
                             public views::WidgetObserver,
                             public views::ContextMenuController,
                             public ExtensionActionIconFactory::Observer {
  public:
+  static const char kViewClassName[];

[sky, 2014/08/04 17:36:54]

nit: there isn't a need to make this public unless an external class needs it.

[tdanderson, 2014/08/05 15:32:32]

Done.

+
   PageActionImageView(LocationBarView* owner,
                       ExtensionAction* page_action,
                       Browser* browser);
   virtual ~PageActionImageView();
 
   ExtensionAction* page_action() { return page_action_; }
 
   int current_tab_id() { return current_tab_id_; }
 
   void set_preview_enabled(bool preview_enabled) {
     preview_enabled_ = preview_enabled;
   }
 
   // Overridden from views::View:
+  virtual const char* GetClassName() const OVERRIDE;
   virtual void GetAccessibleState(ui::AXViewState* state) OVERRIDE;
   virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE;
   virtual void OnMouseReleased(const ui::MouseEvent& event) OVERRIDE;
   virtual bool OnKeyPressed(const ui::KeyEvent& event) OVERRIDE;
+  virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE;
 
   // Overridden from ExtensionContextMenuModel::Delegate
   virtual void InspectPopup() OVERRIDE;
 
   // Overridden from views::WidgetObserver:
   virtual void OnWidgetDestroying(views::Widget* widget) OVERRIDE;
 
   // Overridden from views::ContextMenuController.
   virtual void ShowContextMenuForView(View* source,
                                       const gfx::Point& point,
@@ skipping 61 matching lines @@
   // The extension command accelerator this page action is listening for (to
   // show the popup).
   scoped_ptr<ui::Accelerator> page_action_keybinding_;
 
   scoped_ptr<views::MenuRunner> menu_runner_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(PageActionImageView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_PAGE_ACTION_IMAGE_VIEW_H_