Page action extension icons should handle tap events

chrome/browser/ui/views/location_bar/page_action_image_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/page_action_image_view.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/api/commands/command_service.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "chrome/browser/extensions/extension_action_icon_factory.h"
@@ skipping 15 matching lines @@
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/events/event.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/image/image.h"
 #include "ui/views/controls/menu/menu_runner.h"
 
 using content::WebContents;
 using extensions::LocationBarController;
 using extensions::Extension;
 
+// static
+const char PageActionImageView::kViewClassName[] = "PageActionImageView";
+
 PageActionImageView::PageActionImageView(LocationBarView* owner,
                                          ExtensionAction* page_action,
                                          Browser* browser)
     : owner_(owner),
       page_action_(page_action),
       browser_(browser),
       current_tab_id_(-1),
       preview_enabled_(false),
       popup_(NULL) {
   const Extension* extension = extensions::ExtensionRegistry::Get(
@@ skipping 60 matching lines @@
     case LocationBarController::ACTION_SHOW_CONTEXT_MENU:
       // We are never passing OnClicked a right-click button, so assume that
       // we're never going to be asked to show a context menu.
       // TODO(kalman): if this changes, update this class to pass the real
       // mouse button through to the LocationBarController.
       NOTREACHED();
       break;
   }
 }
 
+const char* PageActionImageView::GetClassName() const {
+  return kViewClassName;
+}
+
 void PageActionImageView::GetAccessibleState(ui::AXViewState* state) {
   state->role = ui::AX_ROLE_BUTTON;
   state->name = base::UTF8ToUTF16(tooltip_);
 }
 
 bool PageActionImageView::OnMousePressed(const ui::MouseEvent& event) {
   // We want to show the bubble on mouse release; that is the standard behavior
   // for buttons.  (Also, triggering on mouse press causes bugs like
   // http://crbug.com/33155.)
   return true;
@@ skipping 14 matching lines @@
 
 bool PageActionImageView::OnKeyPressed(const ui::KeyEvent& event) {
   if (event.key_code() == ui::VKEY_SPACE ||
       event.key_code() == ui::VKEY_RETURN) {
     ExecuteAction(ExtensionPopup::SHOW);
     return true;
   }
   return false;
 }
 
+void PageActionImageView::OnGestureEvent(ui::GestureEvent* event) {
+  if (event->type() == ui::ET_GESTURE_TAP) {
+    ExecuteAction(ExtensionPopup::SHOW);
+    event->SetHandled();
+  }
+}
+
 void PageActionImageView::ShowContextMenuForView(
     View* source,
     const gfx::Point& point,
     ui::MenuSourceType source_type) {
   const Extension* extension = extensions::ExtensionRegistry::Get(
       owner_->profile())->enabled_extensions().GetByID(
           page_action()->extension_id());
   if (!extension->ShowConfigureContextMenus())
     return;
 
@@ skipping 99 matching lines @@
 
   popup_ = ExtensionPopup::ShowPopup(popup_url, browser_, this, arrow,
                                      show_action);
   popup_->GetWidget()->AddObserver(this);
 }
 
 void PageActionImageView::HidePopup() {
   if (popup_)
     popup_->GetWidget()->Close();
 }