Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 429683003: Bring LATC in line with other formats (i.e. write a blitter and (Closed)

Created:
6 years, 4 months ago by krajcevski
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Bring LATC in line with other formats (i.e. write a blitter and an "optimized" compression routine). Committed: https://skia.googlesource.com/skia/+/b5294e8d453866ae0dc5a0304c1ca969ef3c7670

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Patch Set 3 : Update unit tests #

Patch Set 4 : Update unit tests #

Total comments: 2

Patch Set 5 : Update comments and test dimensions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -38 lines) Patch
M src/utils/SkTextureCompressor_ASTC.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/utils/SkTextureCompressor_LATC.cpp View 1 2 chunks +127 lines, -0 lines 0 comments Download
M tests/TextureCompressionTest.cpp View 1 2 3 4 5 chunks +63 lines, -34 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
krajcevski
6 years, 4 months ago (2014-07-29 20:32:08 UTC) #1
robertphillips
lgtm https://codereview.chromium.org/429683003/diff/1/src/utils/SkTextureCompressor_LATC.cpp File src/utils/SkTextureCompressor_LATC.cpp (right): https://codereview.chromium.org/429683003/diff/1/src/utils/SkTextureCompressor_LATC.cpp#newcode298 src/utils/SkTextureCompressor_LATC.cpp:298: // bits of the integer. rm 'register' in ...
6 years, 4 months ago (2014-07-29 20:52:49 UTC) #2
krajcevski
https://codereview.chromium.org/429683003/diff/1/src/utils/SkTextureCompressor_LATC.cpp File src/utils/SkTextureCompressor_LATC.cpp (right): https://codereview.chromium.org/429683003/diff/1/src/utils/SkTextureCompressor_LATC.cpp#newcode298 src/utils/SkTextureCompressor_LATC.cpp:298: // bits of the integer. On 2014/07/29 20:52:49, robertphillips ...
6 years, 4 months ago (2014-07-29 21:08:26 UTC) #3
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-07-29 21:08:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/429683003/20001
6 years, 4 months ago (2014-07-29 21:09:25 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-07-29 21:21:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 21:32:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot/builds/923)
6 years, 4 months ago (2014-07-29 21:32:15 UTC) #8
krajcevski
Updated unit tests, can you take another look?
6 years, 4 months ago (2014-07-30 14:53:56 UTC) #9
robertphillips
lgtm https://codereview.chromium.org/429683003/diff/60001/tests/TextureCompressionTest.cpp File tests/TextureCompressionTest.cpp (right): https://codereview.chromium.org/429683003/diff/60001/tests/TextureCompressionTest.cpp#newcode56 tests/TextureCompressionTest.cpp:56: // by 4, which is the dimensions of ...
6 years, 4 months ago (2014-07-30 15:02:23 UTC) #10
krajcevski
https://codereview.chromium.org/429683003/diff/60001/tests/TextureCompressionTest.cpp File tests/TextureCompressionTest.cpp (right): https://codereview.chromium.org/429683003/diff/60001/tests/TextureCompressionTest.cpp#newcode56 tests/TextureCompressionTest.cpp:56: // by 4, which is the dimensions of R11_EAC ...
6 years, 4 months ago (2014-07-30 15:23:27 UTC) #11
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-07-30 15:23:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/429683003/80001
6 years, 4 months ago (2014-07-30 15:23:56 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 15:34:55 UTC) #14
Message was sent while issue was closed. 
Change committed as b5294e8d453866ae0dc5a0304c1ca969ef3c7670

Powered by Google App Engine
This is Rietveld 408576698