Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 429253003: Webrtc deps roll. (Closed)

Created:
6 years, 4 months ago by Ronghua Wu (Left Chromium)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+943 lines, -1609 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/BUILD.gn View 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.h View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_throttler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_throttler.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/p2p_messages.h View 4 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/media/mock_peer_connection_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/media/mock_peer_connection_impl.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M content/renderer/media/peer_connection_identity_service.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/peer_connection_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_data_channel_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/media_stream_track_metrics.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_track_metrics_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_local_audio_track_adapter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc_audio_capturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_logging.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/host_address_request.h View 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/p2p/host_address_request.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager.cc View 4 chunks +21 lines, -21 lines 0 comments Download
M content/renderer/p2p/ipc_socket_factory.h View 1 chunk +12 lines, -12 lines 0 comments Download
M content/renderer/p2p/ipc_socket_factory.cc View 23 chunks +69 lines, -69 lines 0 comments Download
M content/renderer/p2p/port_allocator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/p2p/port_allocator.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/p2p/socket_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/socket_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/socket_client_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M jingle/glue/channel_socket_adapter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M jingle/glue/channel_socket_adapter.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M jingle/glue/channel_socket_adapter_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M jingle/glue/chrome_async_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/chrome_async_socket.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/glue/chrome_async_socket_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M jingle/glue/jingle_glue_mock_objects.h View 1 chunk +6 lines, -6 lines 0 comments Download
M jingle/glue/logging_unittest.cc View 7 chunks +41 lines, -41 lines 0 comments Download
M jingle/glue/mock_task.h View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/glue/mock_task.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/task_pump.h View 1 chunk +4 lines, -4 lines 0 comments Download
M jingle/glue/task_pump_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/glue/thread_wrapper.h View 4 chunks +21 lines, -21 lines 0 comments Download
M jingle/glue/thread_wrapper.cc View 10 chunks +32 lines, -32 lines 0 comments Download
M jingle/glue/thread_wrapper_unittest.cc View 12 chunks +23 lines, -23 lines 0 comments Download
M jingle/glue/utils.h View 2 chunks +4 lines, -4 lines 0 comments Download
M jingle/glue/utils.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M jingle/notifier/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M jingle/notifier/base/fake_base_task.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/notifier/base/gaia_token_pre_xmpp_auth.h View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/base/gaia_token_pre_xmpp_auth.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M jingle/notifier/base/weak_xmpp_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/base/weak_xmpp_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/weak_xmpp_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/xmpp_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/xmpp_connection_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M jingle/notifier/communicator/connection_settings.h View 3 chunks +3 lines, -3 lines 0 comments Download
M jingle/notifier/communicator/connection_settings.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M jingle/notifier/communicator/connection_settings_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M jingle/notifier/communicator/login.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M jingle/notifier/communicator/login_settings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/listener/push_notifications_listen_task.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/listener/push_notifications_subscribe_task.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/client/plugin/pepper_network_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_network_manager.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.h View 1 chunk +10 lines, -10 lines 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.cc View 12 chunks +33 lines, -33 lines 0 comments Download
M remoting/client/plugin/pepper_port_allocator.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/client/plugin/pepper_port_allocator.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M remoting/client/plugin/pepper_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/client/plugin/pepper_util.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M remoting/host/chromium_port_allocator_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromium_port_allocator_factory.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/protocol/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/chromium_port_allocator.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/protocol/chromium_port_allocator.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M remoting/protocol/chromium_socket_factory.h View 1 chunk +10 lines, -10 lines 0 comments Download
M remoting/protocol/chromium_socket_factory.cc View 11 chunks +42 lines, -42 lines 0 comments Download
M remoting/protocol/chromium_socket_factory_unittest.cc View 3 chunks +23 lines, -23 lines 0 comments Download
M remoting/protocol/jingle_messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_session_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/jingle_session_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/libjingle_transport_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/libjingle_transport_factory.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M remoting/protocol/message_decoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/message_reader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/message_serialization.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/signaling/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/signaling/jingle_info_request.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/signaling/jingle_info_request.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libjingle/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 9 chunks +29 lines, -25 lines 0 comments Download
M third_party/libjingle/libjingle_common.gypi View 2 chunks +0 lines, -204 lines 0 comments Download
M third_party/libjingle/libjingle_nacl.gyp View 4 chunks +190 lines, -0 lines 0 comments Download
M third_party/libjingle/overrides/init_webrtc.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/libjingle/overrides/initialize_module.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D third_party/libjingle/overrides/talk/base/basictypes.h View 1 1 chunk +0 lines, -102 lines 0 comments Download
D third_party/libjingle/overrides/talk/base/constructormagic.h View 1 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/libjingle/overrides/talk/base/logging.h View 1 1 chunk +0 lines, -215 lines 0 comments Download
D third_party/libjingle/overrides/talk/base/logging.cc View 1 1 chunk +0 lines, -311 lines 0 comments Download
D third_party/libjingle/overrides/talk/base/win32socketinit.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ronghua Wu (Left Chromium)
6 years, 4 months ago (2014-07-31 21:40:21 UTC) #1
hellner1
LGTM
6 years, 4 months ago (2014-07-31 22:14:19 UTC) #2
Ronghua Wu (Left Chromium)
Committed patchset #3 manually as r286902 (presubmit successful).
6 years, 4 months ago (2014-07-31 22:19:51 UTC) #3
xiyuan
6 years, 4 months ago (2014-08-01 04:20:57 UTC) #4
Message was sent while issue was closed.
Reverted in https://codereview.chromium.org/435823002.

Besides the issues mentioned in the revert CL, the webrtc roll might also break
chrome os build, e.g.

http://chromegw/i/chromeos/builders/alex%20nightly%20chrome%20PFQ/builds/5778...

chromeos-chrome-38.0.2110.0_rc-r1: FAILED: i686-pc-linux-gnu-g++
-B/usr/x86_64-pc-linux-gnu/i686-pc-linux-gnu/binutils-bin/2.22-gold -MMD -MF
obj/third_party/libjingle/source_internal/talk/p2p/base/libjingle.asyncstuntcpsocket.o.d
-DEXPAT_RELATIVE_PATH -DFEATURE_ENABLE_SSL -DGTEST_RELATIVE_PATH -DHAVE_SRTP
-DHAVE_WEBRTC_VIDEO -DHAVE_WEBRTC_VOICE -DLOGGING_INSIDE_LIBJINGLE
-DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DSRTP_RELATIVE_PATH
-DUSE_WEBRTC_DEV_BRANCH -DENABLE_EXTERNAL_AUTH -DV8_DEPRECATION_WARNINGS
-DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DSSL_USE_NSS
-DHAVE_NSS_SSL_H -DSSL_USE_NSS_RNG -DLINUX -DPOSIX -DGOOGLE_CHROME_BUILD
-DENABLE_RLZ -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1
-DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CRAS=1 -DUSE_GLIB=1
-DUSE_DEFAULT_RENDER_THEME=1 -DUSE_X11=1 -DUSE_XI2_MT=2
-DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1
-DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
-DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DUSE_UDEV -DENABLE_EGLIMAGE=1
-DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1
-DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1
-DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1
-DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_APP_LIST=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1
-DFEATURE_ENABLE_VOICEMAIL -DCHROMEOS -DUSE_NSS=1 -DOS_CHROMEOS=1 -DNDEBUG
-DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0
-Igen/libjingle_shims
-I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libjingle/overrides
-I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libjingle/source_internal
-I../../../../../../../home/chrome-bot/chrome_root/src/third_party/webrtc/overrides
-I../../../../../../../home/chrome-bot/chrome_root/src
-I../../../../../../../home/chrome-bot/chrome_root/src/testing/gtest/include
-I../../../../../../../home/chrome-bot/chrome_root/src/third_party
-I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libyuv/include
-I../../../../../../../home/chrome-bot/chrome_root/src/third_party/usrsctp
-I../../../../../../../home/chrome-bot/chrome_root/src/third_party/webrtc -Igen
-I../../../../../../../home/chrome-bot/chrome_root/src/net/third_party/nss/ssl
-I/usr/include32 -pthread -fno-exceptions -fno-strict-aliasing
-Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe
-fPIC -g -Wno-unused-local-typedefs -pthread
-I/build/x86-alex/usr/include/glib-2.0
-I/build/x86-alex/usr/lib/glib-2.0/include -I/build/x86-alex/usr/include/nss
-I/build/x86-alex/usr/include/nspr -Wno-format -Wno-unused-result -msse2
-mfpmath=sse -mmmx -m32 --sysroot=/build/x86-alex/ -O2 -fno-ident
-fdata-sections -ffunction-sections -fno-unwind-tables
-fno-asynchronous-unwind-tables -g -pipe -march=atom -mtune=atom -mfpmath=sse
-D__google_stl_debug_vector=1 -fno-rtti -fno-threadsafe-statics
-fvisibility-inlines-hidden -Wno-deprecated -std=gnu++11 -Wno-narrowing
-Wno-literal-suffix  -c
../../../../../../../home/chrome-bot/chrome_root/src/third_party/libjingle/source_internal/talk/p2p/base/asyncstuntcpsocket.cc
-o
obj/third_party/libjingle/source_internal/talk/p2p/base/libjingle.asyncstuntcpsocket.o
chromeos-chrome-38.0.2110.0_rc-r1: In file included from
../../../../../../../home/chrome-bot/chrome_root/src/third_party/webrtc/base/socketaddress.h:18:0,
chromeos-chrome-38.0.2110.0_rc-r1:                  from
../../../../../../../home/chrome-bot/chrome_root/src/third_party/webrtc/base/socket.h:29,
chromeos-chrome-38.0.2110.0_rc-r1:                  from
../../../../../../../home/chrome-bot/chrome_root/src/third_party/webrtc/base/asyncpacketsocket.h:16,
chromeos-chrome-38.0.2110.0_rc-r1:                  from
../../../../../../../home/chrome-bot/chrome_root/src/third_party/webrtc/base/asynctcpsocket.h:14,
chromeos-chrome-38.0.2110.0_rc-r1:                  from
../../../../../../../home/chrome-bot/chrome_root/src/third_party/libjingle/source_internal/talk/p2p/base/asyncstuntcpsocket.h:31,
chromeos-chrome-38.0.2110.0_rc-r1:                  from
../../../../../../../home/chrome-bot/chrome_root/src/third_party/libjingle/source_internal/talk/p2p/base/asyncstuntcpsocket.cc:28:
chromeos-chrome-38.0.2110.0_rc-r1:
../../../../../../../home/chrome-bot/chrome_root/src/third_party/webrtc/base/ipaddress.h:43:28:
error: 'in_addr' does not name a type
chromeos-chrome-38.0.2110.0_rc-r1:    explicit IPAddress(const in_addr &ip4) :
family_(AF_INET) {

Powered by Google App Engine
This is Rietveld 408576698