Webrtc deps roll.

Webrtc deps roll.

BUG=N/A
TBR=sergeyu@chromium.org

[hellner1, 2014-07-30 22:58:16]

As reported here https://code.google.com/p/webrtc/issues/detail?id=3379
libjingle is being migrated piece by piece to webrtc. The first piece is the
base-folder. This cl rolls webrtc/libjingle that doesn't use talk/base but
webrtc base to chromium.

Since content, renderer, jingle and libjingle all use talk/base this cl also
includes the redirect of those projects to use webrtc/base instead.

I.e. the change is really only change of include and namespace for those
projects.

Reviewers:
content: jochen
rest: sergeyu (since he is owner of everything else and he has good knowledge of
this effort)

PTAL

[jochen (gone - plz use gerrit), 2014-07-31 14:57:47]

lgtm

[jiayl, 2014-07-31 18:30:10]

https://codereview.chromium.org/429113002/diff/100001/jingle/notifier/DEPS
File jingle/notifier/DEPS (right):

https://codereview.chromium.org/429113002/diff/100001/jingle/notifier/DEPS#ne...
jingle/notifier/DEPS:3: "+talk/base",
shouldn't talk/base be removed?

[hellner1, 2014-07-31 18:54:21]

On 2014/07/31 18:30:10, jiayl wrote:
> https://codereview.chromium.org/429113002/diff/100001/jingle/notifier/DEPS
> File jingle/notifier/DEPS (right):
> 
>
https://codereview.chromium.org/429113002/diff/100001/jingle/notifier/DEPS#ne...
> jingle/notifier/DEPS:3: "+talk/base",
> shouldn't talk/base be removed?

It will. However, Chromium is downstream so it wont happen in this cl.

The reason it hasn't been removed yet is because there are multiple build
systems in several repos that build talk/base. It can't be removed until all
build systems stop using it.

[Ronghua Wu (Left Chromium), 2014-07-31 21:09:04]

libjingle folder lgtm

[hellner1, 2014-07-31 21:11:05]

Reviewers:
+wez for chromoting
+hclam for jingle

[Wez, 2014-07-31 21:22:53]

https://codereview.chromium.org/429113002/diff/120001/remoting/client/plugin/...
File remoting/client/plugin/chromoting_instance.cc (right):

https://codereview.chromium.org/429113002/diff/120001/remoting/client/plugin/...
remoting/client/plugin/chromoting_instance.cc:12: #include <nacl_io/nacl_io.h>
Did you mean to move this? Does the Chromoting PNaCl client build with the order
reversed?

https://codereview.chromium.org/429113002/diff/120001/remoting/client/plugin/...
remoting/client/plugin/chromoting_instance.cc:250: rtc::InitRandom(random_seed,
sizeof(random_seed));
Why rtc and not webrtc?

[Wez, 2014-07-31 21:26:05]

remoting/ LGTM

[hellner1, 2014-07-31 21:36:27]

https://codereview.chromium.org/429113002/diff/120001/remoting/client/plugin/...
File remoting/client/plugin/chromoting_instance.cc (right):

https://codereview.chromium.org/429113002/diff/120001/remoting/client/plugin/...
remoting/client/plugin/chromoting_instance.cc:12: #include <nacl_io/nacl_io.h>
On 2014/07/31 21:22:53, Wez wrote:
> Did you mean to move this? Does the Chromoting PNaCl client build with the
order
> reversed?

I ran http://src.chromium.org/viewvc/chrome/trunk/src/tools/sort-headers.py to
fix the header order of the files I touched.

https://codereview.chromium.org/429113002/diff/120001/remoting/client/plugin/...
remoting/client/plugin/chromoting_instance.cc:250: rtc::InitRandom(random_seed,
sizeof(random_seed));
On 2014/07/31 21:22:53, Wez wrote:
> Why rtc and not webrtc?

Discussed here:
https://docs.google.com/a/google.com/document/d/1jIFupXQO5OX5mmEugjHkoneo72Hq...
and here
https://docs.google.com/a/google.com/document/d/11DDtsAgrIO5xuThqMd7NuTCaM_1N...
basically the merged library contains more than webrtc.

[Alpha Left Google, 2014-07-31 21:36:47]

lgtm

[hellner1, 2014-07-31 21:49:46]

Reviewers:
+palmer: content/common/p2p_messages.h
+darin: */DEPS

[hellner1, 2014-07-31 21:50:36]

Reviewers:
+palmer: content/common/p2p_messages.h
+darin: */DEPS

[palmer, 2014-07-31 21:53:08]

Rubberstamp LGTM.

[Nico, 2014-08-01 00:17:05]

On 2014/07/31 21:50:36, hellner1 wrote:
> Reviewers:
> +palmer: content/common/p2p_messages.h
> +darin: */DEPS

Global DEPS doesn't need owner reviews, and you have owners for all the other
deps files. So you don't need a review from darin.

[hellner1, 2014-08-04 20:26:35]

On 2014/08/01 00:17:05, Nico (away) wrote:
> On 2014/07/31 21:50:36, hellner1 wrote:
> > Reviewers:
> > +palmer: content/common/p2p_messages.h
> > +darin: */DEPS
> 
> Global DEPS doesn't need owner reviews, and you have owners for all the other
> deps files. So you don't need a review from darin.

OK, presubmit script suggested that I added darin (note that it wasn't the
src/DEPS change that complained it was the jingle/glue/DEPS etc). Anyways I got
the go ahead for tbr commit.

[Nico, 2014-08-04 21:23:39]

On 2014/08/04 20:26:35, hellner1 wrote:
> On 2014/08/01 00:17:05, Nico (away) wrote:
> > On 2014/07/31 21:50:36, hellner1 wrote:
> > > Reviewers:
> > > +palmer: content/common/p2p_messages.h
> > > +darin: */DEPS
> > 
> > Global DEPS doesn't need owner reviews, and you have owners for all the
other
> > deps files. So you don't need a review from darin.
> 
> OK, presubmit script suggested that I added darin (note that it wasn't the
> src/DEPS change that complained it was the jingle/glue/DEPS etc). Anyways I
got
> the go ahead for tbr commit.

Sounds good. Did you see that ronghuawu landed this roll 3 days ago (
https://codereview.chromium.org/429253003/ ) and that it got reverted? Do you
have a fix for what caused the revert? (The webrtc revision you're rolling to
looks identical to what he had, but maybe some of the other code is different)

[hellner1, 2014-08-04 21:29:10]

On 2014/08/04 21:23:39, Nico (away) wrote:
> On 2014/08/04 20:26:35, hellner1 wrote:
> > On 2014/08/01 00:17:05, Nico (away) wrote:
> > > On 2014/07/31 21:50:36, hellner1 wrote:
> > > > Reviewers:
> > > > +palmer: content/common/p2p_messages.h
> > > > +darin: */DEPS
> > > 
> > > Global DEPS doesn't need owner reviews, and you have owners for all the
> other
> > > deps files. So you don't need a review from darin.
> > 
> > OK, presubmit script suggested that I added darin (note that it wasn't the
> > src/DEPS change that complained it was the jingle/glue/DEPS etc). Anyways I
> got
> > the go ahead for tbr commit.
> 
> Sounds good. Did you see that ronghuawu landed this roll 3 days ago (
> https://codereview.chromium.org/429253003/ ) and that it got reverted? Do you
> have a fix for what caused the revert? (The webrtc revision you're rolling to
> looks identical to what he had, but maybe some of the other code is different)

Yeah, my local script for making the talk/base->webrtc/base move snuck in an 's'
in a define (probably because I use emacs and must have butter-fingered ctrl-x
ctrl-s and had too many changes in my local git-repo for the script for me to
notice it). It should be fixed by
https://webrtc-codereview.appspot.com/18989004/. Working on verifying it
locally. Will have to pull in a newer DEPS revision for webrtc though so I'll
have to run through all the tests again. Hopefully I can re-commit tomorrow.

[hellner1, 2014-08-22 18:49:27]

Committed as https://codereview.chromium.org/450463002