Source/core/frame/Settings.in - Issue 428633004: Webkit setting for embedders that do not support fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/Settings.in

Issue 428633004: Webkit setting for embedders that do not support fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments and nits Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fullscreen/full-screen-request-not-enabled.html ('K') | « Source/core/dom/FullscreenElementStack.cpp ('k') | Source/web/FullscreenController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/Settings.in

diff --git a/Source/core/frame/Settings.in b/Source/core/frame/Settings.in

index 2215ed15e2e62e75e9422ff81d40c1e3ee3a2c98..94bfa20fb7f35ab528f749ed1e2bd21fa172841c 100644

--- a/Source/core/frame/Settings.in

+++ b/Source/core/frame/Settings.in

@@ -269,3 +269,16 @@ deviceScaleAdjustment type=double, initial=1.0, invalidate=TextAutosizing

# API will return 'false' in that case.

maxBeaconTransmission type=int, initial=16384

+# This value is set to false if the platform does not support full screen.

philipj_slow 2014/07/31 13:15:03 For consistency, replace "full screen" with "fulls

Ignacio Solla 2014/08/01 10:02:44 Done.

+# When set to false all the requests to enter full screen will return an error

+# (onfullscreenerror or webkitfullscreenerror) as specified in the standard:

philipj_slow 2014/07/31 13:15:03 No "on" required in "onfullscreenerror".

Ignacio Solla 2014/08/01 10:02:44 Done.

+# http://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen

+fullScreenEnabled initial=true

+# FIXME: This is a temporary flag and should be removed once

+# the Android WebView framework supports full screen for non-media elements

+# (crbug.com/398485).

+# This value is set to false if the platform does not support full screen

+# for non-media elements. When set to true all the requests to enter full screen

+# on non-media elements will return an error.

+disallowFullscreenForNonMediaElements initial=false