Chromium Code Reviews Chromium Code Reviews
Issue 428633004:
Webkit setting for embedders that do not support fullscreen. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 # Defines properties which are available on the Settings object. | 1 # Defines properties which are available on the Settings object. |
| 2 # | 2 # |
| 3 # Please think carefully before adding a new Setting. Some questions to | 3 # Please think carefully before adding a new Setting. Some questions to |
| 4 # consider are: | 4 # consider are: |
| 5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things | 5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things |
| 6 # which we support either values of at runtime. Features are set at renderer | 6 # which we support either values of at runtime. Features are set at renderer |
| 7 # process startup and are never changed. Features also tend to be set to a | 7 # process startup and are never changed. Features also tend to be set to a |
| 8 # value based on the platform or the stability of the code in question, where | 8 # value based on the platform or the stability of the code in question, where |
| 9 # as settings both codepaths need to be stable. | 9 # as settings both codepaths need to be stable. |
| 10 # - How will you ensure test coverage of all relevant values of your setting? | 10 # - How will you ensure test coverage of all relevant values of your setting? |
| (...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 262 | 262 |
| 263 # This value indicates the maximum number of bytes a document is allowed | 263 # This value indicates the maximum number of bytes a document is allowed |
| 264 # to transmit in Beacons (via navigator.sendBeacon()) -- Beacons are | 264 # to transmit in Beacons (via navigator.sendBeacon()) -- Beacons are |
| 265 # intended to be smaller payloads transmitted as a page is unloading, not | 265 # intended to be smaller payloads transmitted as a page is unloading, not |
| 266 # a general (one-way) network transmission API. | 266 # a general (one-way) network transmission API. |
| 267 # The spec ( https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/Beacon/Overview.h tml ) | 267 # The spec ( https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/Beacon/Overview.h tml ) |
| 268 # does not proscribe an upper limit, but allows for it -- the underlying | 268 # does not proscribe an upper limit, but allows for it -- the underlying |
| 269 # API will return 'false' in that case. | 269 # API will return 'false' in that case. |
| 270 maxBeaconTransmission type=int, initial=16384 | 270 maxBeaconTransmission type=int, initial=16384 |
| 271 | 271 |
| 272 # This value is set to false if the platform does not support full screen. | |
|
philipj_slow
2014/07/31 13:15:03
For consistency, replace "full screen" with "fulls
Ignacio Solla
2014/08/01 10:02:44
Done.
| |
| 273 # When set to false all the requests to enter full screen will return an error | |
| 274 # (onfullscreenerror or webkitfullscreenerror) as specified in the standard: | |
|
philipj_slow
2014/07/31 13:15:03
No "on" required in "onfullscreenerror".
Ignacio Solla
2014/08/01 10:02:44
Done.
| |
| 275 # http://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen | |
| 276 fullScreenEnabled initial=true | |
| 277 | |
| 278 # FIXME: This is a temporary flag and should be removed once | |
| 279 # the Android WebView framework supports full screen for non-media elements | |
| 280 # (crbug.com/398485). | |
| 281 # This value is set to false if the platform does not support full screen | |
| 282 # for non-media elements. When set to true all the requests to enter full screen | |
| 283 # on non-media elements will return an error. | |
| 284 disallowFullscreenForNonMediaElements initial=false | |
| OLD | NEW |
