LayoutTests/fullscreen/full-screen-request-not-enabled.html - Issue 428633004: Webkit setting for embedders that do not support fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fullscreen/full-screen-request-not-enabled.html

Issue 428633004: Webkit setting for embedders that do not support fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments and nits Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements.html ('K') | « LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements-expected.txt ('k') | LayoutTests/fullscreen/full-screen-request-not-enabled-expected.txt » ('j') | Source/core/frame/Settings.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fullscreen/full-screen-request-not-enabled.html

diff --git a/LayoutTests/fullscreen/full-screen-request-not-enabled.html b/LayoutTests/fullscreen/full-screen-request-not-enabled.html

new file mode 100644

index 0000000000000000000000000000000000000000..8614ad9ae8bda717cdb2da4066721ee1a137dbf6

--- /dev/null

+++ b/LayoutTests/fullscreen/full-screen-request-not-enabled.html

@@ -0,0 +1,18 @@

+<body>

falken 2014/07/31 14:53:10 ditto about <body>

Ignacio Solla 2014/08/01 10:02:44 Done.

+<script src="full-screen-test.js"></script>

+<video id="video" width="300"></video>

+<div>Tests for the fullScreenEnabled setting which will be set to false

+in those platforms where full screen is not supported.

+<script>

+ if (window.internals) {

+ window.internals.settings.setFullScreenEnabled(false);

+ waitForEvent(document, 'webkitfullscreenchange', function() {

+ logResult("Entered full screen.", false);

falken 2014/07/31 14:53:10 Seems like these arguments are switched? function

Ignacio Solla 2014/08/01 10:02:44 Done.

+ endTest();

+ });

+ waitForEventAndEnd(document, 'webkitfullscreenerror');

+ runWithKeyDown(function(){document.getElementById('video').webkitRequestFullScreen()});

+ }

+</script>

falken 2014/07/31 14:53:10 nit: extra line here

Ignacio Solla 2014/08/01 10:02:44 Done.