Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 428363002: Add a UseCounter for <body bgproperties=fixed> (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Project:
blink
Visibility:
Public.

Description

Add a UseCounter for <body bgproperties=fixed> This is a survivor of the first browser wars, implemented by Internet Explorer but not Netscape. It was never standardized, so measure usage to figure out the best path forward. For the archaeologist: http://lists.w3.org/Archives/Public/www-talk/1996JulAug/0177.html http://lists.w3.org/Archives/Public/www-talk/1997SepOct/0008.html http://lists.w3.org/Archives/Public/www-html/1998Oct/0016.html https://bugzilla.mozilla.org/show_bug.cgi?id=7474 https://projects.kde.org/projects/kde/kdelibs/repository/revisions/34867245 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179314

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
rebase
6 years, 4 months ago (2014-07-31 14:10:49 UTC) #1
philipj_slow
PTAL
6 years, 4 months ago (2014-07-31 14:14:44 UTC) #2
Mike West
lgtm
6 years, 4 months ago (2014-07-31 14:28:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/428363002/20001
6 years, 4 months ago (2014-07-31 14:28:36 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 15:21:21 UTC) #5
Message was sent while issue was closed.
Change committed as 179314

Powered by Google App Engine
This is Rietveld 408576698