Source/core/html/HTMLBodyElement.cpp - Issue 428363002: Add a UseCounter for <body bgproperties=fixed>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLBodyElement.cpp

Issue 428363002: Add a UseCounter for <body bgproperties=fixed> (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLBodyElement.cpp

diff --git a/Source/core/html/HTMLBodyElement.cpp b/Source/core/html/HTMLBodyElement.cpp

index 85bf86f0ed8c25b624ac9069c54bf94e9bbac3c7..7b25fadc03bf6aedd7eb8caf191c3fa2e86308de 100644

--- a/Source/core/html/HTMLBodyElement.cpp

+++ b/Source/core/html/HTMLBodyElement.cpp

@@ -33,6 +33,7 @@

#include "core/dom/Attribute.h"

#include "core/frame/FrameView.h"

#include "core/frame/LocalFrame.h"

+#include "core/frame/UseCounter.h"

#include "core/html/HTMLFrameElementBase.h"

#include "core/html/parser/HTMLParserIdioms.h"

#include "core/rendering/RenderBox.h"

@@ -81,8 +82,10 @@ void HTMLBodyElement::collectStyleForPresentationAttribute(const QualifiedName&

} else if (name == textAttr) {

addHTMLColorToStyle(style, CSSPropertyColor, value);

} else if (name == bgpropertiesAttr) {

- if (equalIgnoringCase(value, "fixed"))

- addPropertyToPresentationAttributeStyle(style, CSSPropertyBackgroundAttachment, CSSValueFixed);

+ if (equalIgnoringCase(value, "fixed")) {

+ UseCounter::count(document(), UseCounter::BgPropertiesFixed);

+ addPropertyToPresentationAttributeStyle(style, CSSPropertyBackgroundAttachment, CSSValueFixed);

+ }

} else

HTMLElement::collectStyleForPresentationAttribute(name, value, style);

}

« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »