Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 428263004: Revert of Delete mediaPlaybackRequiresUserGesture (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
Reviewers:
philipj_slow, eseidel
CC:
adamk, blink-reviews, blink-reviews-html_chromium.org, chrishtr, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, jamesr, nessy, vcarbune.chromium
Project:
blink
Visibility:
Public.

Description

Revert of Delete mediaPlaybackRequiresUserGesture (https://codereview.chromium.org/414543002/) Reason for revert: We're going to gather some data about how users react to autoplaying videos in order to decide whether to keep this restriction Original issue's description: > Delete mediaPlaybackRequiresUserGesture > > The Android framework does not require a user gesture to begin media playback. > The web shouldn't have that restriction either. > > BUG=178297 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178731 TBR=eseidel@chromium.org,philipj@opera.com NOTREECHECKS=true NOTRY=true BUG=178297 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -3 lines) Patch
M LayoutTests/FlakyTests View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/media/no-autoplay-with-user-gesture-requirement.html View 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/media/no-autoplay-with-user-gesture-requirement-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/media/video-capture-canvas.html View 1 chunk +69 lines, -0 lines 0 comments Download
A LayoutTests/media/video-capture-canvas-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/media/video-capture-preview.html View 1 chunk +69 lines, -0 lines 0 comments Download
A LayoutTests/media/video-capture-preview-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/media/video-play-require-user-gesture.html View 1 chunk +74 lines, -0 lines 0 comments Download
A LayoutTests/media/video-play-require-user-gesture-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 7 chunks +17 lines, -2 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
Created Revert of Delete mediaPlaybackRequiresUserGesture
6 years, 4 months ago (2014-08-01 06:18:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/428263004/1
6 years, 4 months ago (2014-08-01 06:18:40 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 06:19:45 UTC) #3
Message was sent while issue was closed. 
Change committed as 179369

Powered by Google App Engine
This is Rietveld 408576698