Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 414543002: Delete mediaPlaybackRequiresUserGesture (Closed)

Created:
6 years, 5 months ago by abarth-chromium
Modified:
6 years, 5 months ago
Reviewers:
philipj_slow, eseidel
CC:
adamk, blink-reviews, blink-reviews-html_chromium.org, chrishtr, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, jamesr, nessy, vcarbune.chromium
Project:
blink
Visibility:
Public.

Description

Delete mediaPlaybackRequiresUserGesture The Android framework does not require a user gesture to begin media playback. The web shouldn't have that restriction either. BUG=178297 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178731

Patch Set 1 #

Patch Set 2 : Remove tests of this setting #

Total comments: 1

Patch Set 3 : Remove extra header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -333 lines) Patch
M LayoutTests/FlakyTests View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/media/no-autoplay-with-user-gesture-requirement.html View 1 1 chunk +0 lines, -41 lines 0 comments Download
D LayoutTests/media/no-autoplay-with-user-gesture-requirement-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/media/video-capture-canvas.html View 1 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/media/video-capture-canvas-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/media/video-capture-preview.html View 1 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/media/video-capture-preview-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/media/video-play-require-user-gesture.html View 1 1 chunk +0 lines, -74 lines 0 comments Download
D LayoutTests/media/video-play-require-user-gesture-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 7 chunks +2 lines, -17 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (0 generated)
eseidel
Can you help me understand this behavior? Previously an <audio> element wouldn't start playing until ...
6 years, 5 months ago (2014-07-22 19:24:39 UTC) #1
eseidel
It appears that iOS Safari has similar code, which appears to be enabled by default: ...
6 years, 5 months ago (2014-07-22 19:48:23 UTC) #2
abarth-chromium
On 2014/07/22 at 19:48:23, eseidel wrote: > It appears that iOS Safari has similar code, ...
6 years, 5 months ago (2014-07-22 19:51:20 UTC) #3
abarth-chromium
On 2014/07/22 at 19:24:39, eseidel wrote: > Can you help me understand this behavior? > ...
6 years, 5 months ago (2014-07-22 19:52:09 UTC) #4
eseidel
On 2014/07/22 19:51:20, abarth wrote: > On 2014/07/22 at 19:48:23, eseidel wrote: > > It ...
6 years, 5 months ago (2014-07-22 20:08:41 UTC) #5
eseidel
On 2014/07/22 19:52:09, abarth wrote: > On 2014/07/22 at 19:24:39, eseidel wrote: > > Can ...
6 years, 5 months ago (2014-07-22 20:09:54 UTC) #6
esprehn
On 2014/07/22 at 20:09:54, eseidel wrote: > On 2014/07/22 19:52:09, abarth wrote: > > On ...
6 years, 5 months ago (2014-07-22 20:22:26 UTC) #7
abarth-chromium
On 2014/07/22 at 20:22:26, esprehn wrote: > The other side of this is http://features.en.softonic.com/how-to-stop-video-auto-play-on-the-facebook-app (there's ...
6 years, 5 months ago (2014-07-22 20:41:21 UTC) #8
philipj_slow
Yes please, this fixes issue 178297. I investigated this a while back and wrote a ...
6 years, 5 months ago (2014-07-22 22:55:04 UTC) #9
philipj_slow
https://codereview.chromium.org/414543002/diff/20001/Source/core/html/HTMLMediaElement.cpp File Source/core/html/HTMLMediaElement.cpp (left): https://codereview.chromium.org/414543002/diff/20001/Source/core/html/HTMLMediaElement.cpp#oldcode351 Source/core/html/HTMLMediaElement.cpp:351: if (document.settings() && document.settings()->mediaPlaybackRequiresUserGesture()) This was the last user ...
6 years, 5 months ago (2014-07-22 22:57:16 UTC) #10
abarth-chromium
On 2014/07/22 at 22:57:16, philipj wrote: > This was the last user of Settings, so ...
6 years, 5 months ago (2014-07-22 23:06:40 UTC) #11
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 5 months ago (2014-07-22 23:06:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/414543002/40001
6 years, 5 months ago (2014-07-22 23:08:17 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-23 00:47:33 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 01:25:35 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/16637)
6 years, 5 months ago (2014-07-23 01:25:36 UTC) #16
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 5 months ago (2014-07-23 01:36:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/414543002/40001
6 years, 5 months ago (2014-07-23 01:37:41 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-23 03:30:42 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 04:05:46 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/16660)
6 years, 5 months ago (2014-07-23 04:05:47 UTC) #21
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 5 months ago (2014-07-23 04:08:59 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/414543002/40001
6 years, 5 months ago (2014-07-23 04:09:31 UTC) #23
commit-bot: I haz the power
Change committed as 178731
6 years, 5 months ago (2014-07-23 04:49:57 UTC) #24
qinmin
On 2014/07/23 04:49:57, I haz the power (commit-bot) wrote: > Change committed as 178731 Hi, ...
6 years, 5 months ago (2014-07-23 14:57:31 UTC) #25
abarth-chromium
6 years, 4 months ago (2014-08-01 06:18:07 UTC) #26
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/428263004/ by abarth@chromium.org.

The reason for reverting is: We're going to gather some data about how users
react to autoplaying videos in order to decide whether to keep this restriction.

Powered by Google App Engine
This is Rietveld 408576698