Issue 427803002: DevTools: nits: introduce a handy asBool(bool*) and use across agents.

Issue 427803002: DevTools: nits: introduce a handy asBool(bool*) and use across agents. (Closed)

Created:
6 years, 4 months ago by aandrey

Modified:
6 years, 4 months ago

Reviewers:
yurys, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: nits: introduce a handy asBool(bool*) and use across agents. R=loislo, yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179157

Patch Set 1 #

Total comments: 3

Patch Set 2 : addressed #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -41 lines)			Patch
M	Source/core/inspector/InspectorBaseAgent.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorDOMAgent.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorDebuggerAgent.cpp	View		9 chunks	+10 lines, -16 lines	0 comments	Download
M	Source/core/inspector/InspectorHeapProfilerAgent.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/inspector/InspectorInputAgent.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/inspector/InspectorPageAgent.cpp	View		4 chunks	+3 lines, -6 lines	0 comments	Download
M	Source/core/inspector/InspectorRuntimeAgent.cpp	View		2 chunks	+2 lines, -8 lines	0 comments	Download
M	Source/core/inspector/InspectorTimelineAgent.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

yurys

https://codereview.chromium.org/427803002/diff/1/Source/core/inspector/InspectorCSSAgent.cpp File Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/427803002/diff/1/Source/core/inspector/InspectorCSSAgent.cpp#newcode673 Source/core/inspector/InspectorCSSAgent.cpp:673: if (!elementPseudoId && asBool(includePseudo, true)) { Can we fix ...

6 years, 4 months ago (2014-07-29 13:48:05 UTC) #2

aandrey

ptal https://codereview.chromium.org/427803002/diff/1/Source/core/inspector/InspectorCSSAgent.cpp File Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/427803002/diff/1/Source/core/inspector/InspectorCSSAgent.cpp#newcode673 Source/core/inspector/InspectorCSSAgent.cpp:673: if (!elementPseudoId && asBool(includePseudo, true)) { On 2014/07/29 ...

6 years, 4 months ago (2014-07-29 13:51:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/427803002/20001

6 years, 4 months ago (2014-07-29 14:01:34 UTC) #6

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...

6 years, 4 months ago (2014-07-29 15:06:30 UTC) #7

Message was sent while issue was closed.

Change committed as 179157

Expand Messages | Collapse Messages