Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: Source/core/inspector/InspectorTimelineAgent.cpp

Issue 427803002: DevTools: nits: introduce a handy asBool(bool*) and use across agents. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/InspectorRuntimeAgent.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 if (isStarted()) { 358 if (isStarted()) {
359 *errorString = "Timeline is already started"; 359 *errorString = "Timeline is already started";
360 return; 360 return;
361 } 361 }
362 362
363 if (maxCallStackDepth && *maxCallStackDepth >= 0) 363 if (maxCallStackDepth && *maxCallStackDepth >= 0)
364 m_maxCallStackDepth = *maxCallStackDepth; 364 m_maxCallStackDepth = *maxCallStackDepth;
365 else 365 else
366 m_maxCallStackDepth = 5; 366 m_maxCallStackDepth = 5;
367 367
368 if (bufferEvents && *bufferEvents) { 368 if (asBool(bufferEvents)) {
369 m_bufferedEvents = TypeBuilder::Array<TimelineEvent>::create(); 369 m_bufferedEvents = TypeBuilder::Array<TimelineEvent>::create();
370 m_lastProgressTimestamp = timestamp(); 370 m_lastProgressTimestamp = timestamp();
371 } 371 }
372 372
373 if (liveEvents) 373 if (liveEvents)
374 setLiveEvents(*liveEvents); 374 setLiveEvents(*liveEvents);
375 375
376 m_state->setLong(TimelineAgentState::timelineMaxCallStackDepth, m_maxCallSta ckDepth); 376 m_state->setLong(TimelineAgentState::timelineMaxCallStackDepth, m_maxCallSta ckDepth);
377 m_state->setBoolean(TimelineAgentState::includeCounters, includeCounters && *includeCounters); 377 m_state->setBoolean(TimelineAgentState::includeCounters, asBool(includeCount ers));
378 m_state->setBoolean(TimelineAgentState::includeGPUEvents, includeGPUEvents & & *includeGPUEvents); 378 m_state->setBoolean(TimelineAgentState::includeGPUEvents, asBool(includeGPUE vents));
379 m_state->setBoolean(TimelineAgentState::bufferEvents, bufferEvents && *buffe rEvents); 379 m_state->setBoolean(TimelineAgentState::bufferEvents, asBool(bufferEvents));
380 m_state->setString(TimelineAgentState::liveEvents, liveEvents ? *liveEvents : ""); 380 m_state->setString(TimelineAgentState::liveEvents, liveEvents ? *liveEvents : "");
381 381
382 innerStart(); 382 innerStart();
383 bool fromConsole = false; 383 bool fromConsole = false;
384 m_frontend->started(&fromConsole); 384 m_frontend->started(&fromConsole);
385 } 385 }
386 386
387 bool InspectorTimelineAgent::isStarted() 387 bool InspectorTimelineAgent::isStarted()
388 { 388 {
389 return m_state->getBoolean(TimelineAgentState::started); 389 return m_state->getBoolean(TimelineAgentState::started);
(...skipping 971 matching lines...) Expand 10 before | Expand all | Expand 10 after
1361 visitor->trace(m_timelineAgent); 1361 visitor->trace(m_timelineAgent);
1362 } 1362 }
1363 1363
1364 void TimelineThreadState::trace(Visitor* visitor) 1364 void TimelineThreadState::trace(Visitor* visitor)
1365 { 1365 {
1366 visitor->trace(recordStack); 1366 visitor->trace(recordStack);
1367 } 1367 }
1368 1368
1369 } // namespace blink 1369 } // namespace blink
1370 1370
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorRuntimeAgent.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698