Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 427803002: DevTools: nits: introduce a handy asBool(bool*) and use across agents. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 1223 matching lines...) Expand 10 before | Expand all | Expand 10 after
1234 highlightConfig->border = parseConfigColor("borderColor", highlightInspector Object); 1234 highlightConfig->border = parseConfigColor("borderColor", highlightInspector Object);
1235 highlightConfig->margin = parseConfigColor("marginColor", highlightInspector Object); 1235 highlightConfig->margin = parseConfigColor("marginColor", highlightInspector Object);
1236 highlightConfig->eventTarget = parseConfigColor("eventTargetColor", highligh tInspectorObject); 1236 highlightConfig->eventTarget = parseConfigColor("eventTargetColor", highligh tInspectorObject);
1237 return highlightConfig.release(); 1237 return highlightConfig.release();
1238 } 1238 }
1239 1239
1240 void InspectorDOMAgent::setInspectModeEnabled(ErrorString* errorString, bool ena bled, const bool* inspectUAShadowDOM, const RefPtr<JSONObject>* highlightConfig) 1240 void InspectorDOMAgent::setInspectModeEnabled(ErrorString* errorString, bool ena bled, const bool* inspectUAShadowDOM, const RefPtr<JSONObject>* highlightConfig)
1241 { 1241 {
1242 if (enabled && !pushDocumentUponHandlelessOperation(errorString)) 1242 if (enabled && !pushDocumentUponHandlelessOperation(errorString))
1243 return; 1243 return;
1244 SearchMode searchMode = enabled ? (inspectUAShadowDOM && *inspectUAShadowDOM ? SearchingForUAShadow : SearchingForNormal) : NotSearching; 1244 SearchMode searchMode = enabled ? (asBool(inspectUAShadowDOM) ? SearchingFor UAShadow : SearchingForNormal) : NotSearching;
1245 setSearchingForNode(errorString, searchMode, highlightConfig ? highlightConf ig->get() : 0); 1245 setSearchingForNode(errorString, searchMode, highlightConfig ? highlightConf ig->get() : 0);
1246 } 1246 }
1247 1247
1248 void InspectorDOMAgent::highlightRect(ErrorString*, int x, int y, int width, int height, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor ) 1248 void InspectorDOMAgent::highlightRect(ErrorString*, int x, int y, int width, int height, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor )
1249 { 1249 {
1250 OwnPtr<FloatQuad> quad = adoptPtr(new FloatQuad(FloatRect(x, y, width, heigh t))); 1250 OwnPtr<FloatQuad> quad = adoptPtr(new FloatQuad(FloatRect(x, y, width, heigh t)));
1251 innerHighlightQuad(quad.release(), color, outlineColor); 1251 innerHighlightQuad(quad.release(), color, outlineColor);
1252 } 1252 }
1253 1253
1254 void InspectorDOMAgent::highlightQuad(ErrorString* errorString, const RefPtr<JSO NArray>& quadArray, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* o utlineColor) 1254 void InspectorDOMAgent::highlightQuad(ErrorString* errorString, const RefPtr<JSO NArray>& quadArray, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* o utlineColor)
(...skipping 938 matching lines...) Expand 10 before | Expand all | Expand 10 after
2193 visitor->trace(m_searchResults); 2193 visitor->trace(m_searchResults);
2194 #endif 2194 #endif
2195 visitor->trace(m_history); 2195 visitor->trace(m_history);
2196 visitor->trace(m_domEditor); 2196 visitor->trace(m_domEditor);
2197 visitor->trace(m_listener); 2197 visitor->trace(m_listener);
2198 InspectorBaseAgent::trace(visitor); 2198 InspectorBaseAgent::trace(visitor);
2199 } 2199 }
2200 2200
2201 } // namespace blink 2201 } // namespace blink
2202 2202
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorBaseAgent.h ('k') | Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698