Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 427673004: Oilpan: Move AnimationNode::EventDelegate to oilpan's heap (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Project:
blink
Visibility:
Public.

Description

Oilpan: Move AnimationNode::EventDelegate to oilpan's heap This CL removes raw Element* pointers from the EventDelegate hierarchy. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179119

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -16 lines) Patch
M Source/core/animation/Animation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/Animation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationNode.h View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/animation/AnimationNode.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/animation/AnimationNodeTest.cpp View 1 2 chunks +9 lines, -3 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.h View 2 chunks +6 lines, -2 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 4 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
haraken
PTAL
6 years, 4 months ago (2014-07-28 22:14:09 UTC) #1
tkent
https://codereview.chromium.org/427673004/diff/1/Source/core/animation/AnimationNodeTest.cpp File Source/core/animation/AnimationNodeTest.cpp (right): https://codereview.chromium.org/427673004/diff/1/Source/core/animation/AnimationNodeTest.cpp#newcode98 Source/core/animation/AnimationNodeTest.cpp:98: void trace(Visitor* visitor) OVERRIDE This should be virtual, and ...
6 years, 4 months ago (2014-07-28 23:36:19 UTC) #2
haraken
https://codereview.chromium.org/427673004/diff/1/Source/core/animation/AnimationNodeTest.cpp File Source/core/animation/AnimationNodeTest.cpp (right): https://codereview.chromium.org/427673004/diff/1/Source/core/animation/AnimationNodeTest.cpp#newcode98 Source/core/animation/AnimationNodeTest.cpp:98: void trace(Visitor* visitor) OVERRIDE On 2014/07/28 23:36:19, tkent wrote: ...
6 years, 4 months ago (2014-07-28 23:53:24 UTC) #3
tkent
lgtm
6 years, 4 months ago (2014-07-28 23:57:04 UTC) #4
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-07-29 00:01:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/427673004/20001
6 years, 4 months ago (2014-07-29 00:02:13 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-29 01:47:11 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 02:57:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19359)
6 years, 4 months ago (2014-07-29 02:57:17 UTC) #9
zerny-chromium
lgtm
6 years, 4 months ago (2014-07-29 06:55:10 UTC) #10
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-07-29 10:00:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/427673004/20001
6 years, 4 months ago (2014-07-29 10:00:36 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 10:34:51 UTC) #13
Message was sent while issue was closed. 
Change committed as 179119

Powered by Google App Engine
This is Rietveld 408576698