Oilpan: Move AnimationNode::EventDelegate to oilpan's heap

Source/core/animation/AnimationNodeTest.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 56 matching lines @@
     }
 
     void updateInheritedTime(double time, TimingUpdateReason reason)
     {
         m_eventDelegate->reset();
         AnimationNode::updateInheritedTime(time, reason);
     }
 
     virtual void updateChildrenAndEffects() const OVERRIDE { }
     void willDetach() { }
-    TestAnimationNodeEventDelegate* eventDelegate() { return m_eventDelegate; }
+    TestAnimationNodeEventDelegate* eventDelegate() { return m_eventDelegate.get(); }
     virtual double calculateTimeToEffectChange(bool forwards, double localTime, double timeToNextIteration) const OVERRIDE
     {
         m_localTime = localTime;
         m_timeToNextIteration = timeToNextIteration;
         return -1;
     }
     double takeLocalTime()
     {
         const double result = m_localTime;
         m_localTime = nullValue();
         return result;
     }
 
     double takeTimeToNextIteration()
     {
         const double result = m_timeToNextIteration;
         m_timeToNextIteration = nullValue();
         return result;
     }
 
+    void trace(Visitor* visitor) OVERRIDE

[tkent, 2014/07/28 23:36:19]

This should be virtual, and call AnimationNode::trace().

[haraken, 2014/07/28 23:53:24]

Done.

+    {
+        visitor->trace(m_eventDelegate);
+    }
+
 private:
     TestAnimationNode(const Timing& specified, TestAnimationNodeEventDelegate* eventDelegate)
-        : AnimationNode(specified, adoptPtr(eventDelegate))
+        : AnimationNode(specified, adoptPtrWillBeNoop(eventDelegate))
         , m_eventDelegate(eventDelegate)
     {
     }
 
-    TestAnimationNodeEventDelegate* m_eventDelegate;
+    RawPtrWillBeMember<TestAnimationNodeEventDelegate> m_eventDelegate;
     mutable double m_localTime;
     mutable double m_timeToNextIteration;
 };
 
 TEST(AnimationAnimationNodeTest, Sanity)
 {
     Timing timing;
     timing.iterationDuration = 2;
     RefPtrWillBeRawPtr<TestAnimationNode> animationNode = TestAnimationNode::create(timing);
 
@@ skipping 650 matching lines @@
     EXPECT_TRUE(std::isinf(animationNode->takeTimeToNextIteration()));
 
     // Item has finished.
     animationNode->updateInheritedTime(3.5);
     EXPECT_EQ(AnimationNode::PhaseAfter, animationNode->phase());
     EXPECT_EQ(3.5, animationNode->takeLocalTime());
     EXPECT_TRUE(std::isinf(animationNode->takeTimeToNextIteration()));
 }
 
 }