Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 427493002: [fsp] Do not allow write operations on read only file systems. (Closed)

Created:
6 years, 4 months ago by mtomasz
Modified:
6 years, 4 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Do not allow write operations on read only file systems. A writable option for provided file systems has been added recently. This CL adds checks at early stage to fail writing related operations on file systems which were not mounted as R/W. TEST=unit_tests: *FileSystemProvider*ReadOnly* BUG=393506 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -2 lines) Patch
M chrome/browser/chromeos/file_system_provider/operations/copy_entry.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/copy_entry_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/create_directory.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/create_directory_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/create_file.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/create_file_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/delete_entry.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/delete_entry_unittest.cc View 2 chunks +24 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/move_entry.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/truncate.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/truncate_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/test_util/test_util.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mtomasz
@hirono: PTAL. Thanks.
6 years, 4 months ago (2014-07-28 06:08:28 UTC) #1
hirono
lgtm
6 years, 4 months ago (2014-07-28 06:57:56 UTC) #2
mtomasz
On 2014/07/28 06:57:56, hirono wrote: > lgtm Thanks!
6 years, 4 months ago (2014-07-28 07:34:14 UTC) #3
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 4 months ago (2014-07-28 07:34:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/427493002/1
6 years, 4 months ago (2014-07-28 07:35:13 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 08:48:51 UTC) #6
Message was sent while issue was closed.
Change committed as 285878

Powered by Google App Engine
This is Rietveld 408576698