chrome/browser/chromeos/file_system_provider/operations/open_file.cc - Issue 427493002: [fsp] Do not allow write operations on read only file systems.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/open_file.cc

Issue 427493002: [fsp] Do not allow write operations on read only file systems. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc ('k') | chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/open_file.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/open_file.cc b/chrome/browser/chromeos/file_system_provider/operations/open_file.cc

index 8a1a3617f8e4d4d721a4899ed9ee88085cfccc13..93c930f4fed32c957e8e0ac228247df1eb89cc0f 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/open_file.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/open_file.cc

@@ -29,6 +29,11 @@ OpenFile::~OpenFile() {

}

bool OpenFile::Execute(int request_id) {

+ if (!file_system_info_.writable() &&

+ mode_ == ProvidedFileSystemInterface::OPEN_FILE_MODE_WRITE) {

+ return false;

+ }

scoped_ptr<base::DictionaryValue> values(new base::DictionaryValue);

values->SetString("filePath", file_path_.AsUTF8Unsafe());