Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: chrome/browser/chromeos/file_system_provider/operations/delete_entry.cc

Issue 427493002: [fsp] Do not allow write operations on read only file systems. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/file_system_provider/operations/delete_entry.h " 5 #include "chrome/browser/chromeos/file_system_provider/operations/delete_entry.h "
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "chrome/common/extensions/api/file_system_provider.h" 9 #include "chrome/common/extensions/api/file_system_provider.h"
10 #include "chrome/common/extensions/api/file_system_provider_internal.h" 10 #include "chrome/common/extensions/api/file_system_provider_internal.h"
(...skipping 10 matching lines...) Expand all
21 : Operation(event_router, file_system_info), 21 : Operation(event_router, file_system_info),
22 entry_path_(entry_path), 22 entry_path_(entry_path),
23 recursive_(recursive), 23 recursive_(recursive),
24 callback_(callback) { 24 callback_(callback) {
25 } 25 }
26 26
27 DeleteEntry::~DeleteEntry() { 27 DeleteEntry::~DeleteEntry() {
28 } 28 }
29 29
30 bool DeleteEntry::Execute(int request_id) { 30 bool DeleteEntry::Execute(int request_id) {
31 if (!file_system_info_.writable())
32 return false;
33
31 scoped_ptr<base::DictionaryValue> values(new base::DictionaryValue); 34 scoped_ptr<base::DictionaryValue> values(new base::DictionaryValue);
32 values->SetString("entryPath", entry_path_.AsUTF8Unsafe()); 35 values->SetString("entryPath", entry_path_.AsUTF8Unsafe());
33 values->SetBoolean("recursive", recursive_); 36 values->SetBoolean("recursive", recursive_);
34 37
35 return SendEvent( 38 return SendEvent(
36 request_id, 39 request_id,
37 extensions::api::file_system_provider::OnDeleteEntryRequested::kEventName, 40 extensions::api::file_system_provider::OnDeleteEntryRequested::kEventName,
38 values.Pass()); 41 values.Pass());
39 } 42 }
40 43
41 void DeleteEntry::OnSuccess(int /* request_id */, 44 void DeleteEntry::OnSuccess(int /* request_id */,
42 scoped_ptr<RequestValue> /* result */, 45 scoped_ptr<RequestValue> /* result */,
43 bool has_more) { 46 bool has_more) {
44 callback_.Run(base::File::FILE_OK); 47 callback_.Run(base::File::FILE_OK);
45 } 48 }
46 49
47 void DeleteEntry::OnError(int /* request_id */, 50 void DeleteEntry::OnError(int /* request_id */,
48 scoped_ptr<RequestValue> /* result */, 51 scoped_ptr<RequestValue> /* result */,
49 base::File::Error error) { 52 base::File::Error error) {
50 callback_.Run(error); 53 callback_.Run(error);
51 } 54 }
52 55
53 } // namespace operations 56 } // namespace operations
54 } // namespace file_system_provider 57 } // namespace file_system_provider
55 } // namespace chromeos 58 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698