Start the process of choosing the correct compression format

Start the process of choosing the correct compression format

Committed: https://skia.googlesource.com/skia/+/b3abe90145b988883c9882de1ac42da963adbf67

[robertphillips, 2014-07-30 12:15:50]

https://codereview.chromium.org/427093004/diff/1/src/gpu/GrSWMaskHelper.cpp
File src/gpu/GrSWMaskHelper.cpp (right):

https://codereview.chromium.org/427093004/diff/1/src/gpu/GrSWMaskHelper.cpp#n...
src/gpu/GrSWMaskHelper.cpp:53: #if GR_COMPRESS_ALPHA_MASK
I would reverse the order of the arguments.
Would passing in the caps object make sense since it seems to be the least
powerful object required to get the job done?

https://codereview.chromium.org/427093004/diff/1/src/gpu/GrSWMaskHelper.cpp#n...
src/gpu/GrSWMaskHelper.cpp:71: result = true;
We usually only use #error in preprocessor-ish code. How does this compile?

https://codereview.chromium.org/427093004/diff/1/src/gpu/GrSWMaskHelper.h
File src/gpu/GrSWMaskHelper.h (right):

https://codereview.chromium.org/427093004/diff/1/src/gpu/GrSWMaskHelper.h#new...
src/gpu/GrSWMaskHelper.h:104: 
// Should the mask be compressed? If true, fCompressedFormat is always valid. ?

https://codereview.chromium.org/427093004/diff/1/src/gpu/GrSWMaskHelper.h#new...
src/gpu/GrSWMaskHelper.h:105: bool                        fCompressMask;
// Only set when 'fCompressMask' is true. ?

[krajcevski, 2014-07-30 15:10:20]

https://codereview.chromium.org/427093004/diff/1/src/gpu/GrSWMaskHelper.cpp
File src/gpu/GrSWMaskHelper.cpp (right):

https://codereview.chromium.org/427093004/diff/1/src/gpu/GrSWMaskHelper.cpp#n...
src/gpu/GrSWMaskHelper.cpp:53: #if GR_COMPRESS_ALPHA_MASK
On 2014/07/30 12:15:49, robertphillips wrote:
> I would reverse the order of the arguments.
> Would passing in the caps object make sense since it seems to be the least
> powerful object required to get the job done?

Done.

https://codereview.chromium.org/427093004/diff/1/src/gpu/GrSWMaskHelper.cpp#n...
src/gpu/GrSWMaskHelper.cpp:71: result = true;
On 2014/07/30 12:15:49, robertphillips wrote:
> We usually only use #error in preprocessor-ish code. How does this compile?

Done.

https://codereview.chromium.org/427093004/diff/1/src/gpu/GrSWMaskHelper.h
File src/gpu/GrSWMaskHelper.h (right):

https://codereview.chromium.org/427093004/diff/1/src/gpu/GrSWMaskHelper.h#new...
src/gpu/GrSWMaskHelper.h:104: 
On 2014/07/30 12:15:50, robertphillips wrote:
> // Should the mask be compressed? If true, fCompressedFormat is always valid.
?

Done.

https://codereview.chromium.org/427093004/diff/1/src/gpu/GrSWMaskHelper.h#new...
src/gpu/GrSWMaskHelper.h:105: bool                        fCompressMask;
On 2014/07/30 12:15:49, robertphillips wrote:
> // Only set when 'fCompressMask' is true. ?

Done.

[krajcevski, 2014-07-30 19:38:51]

Updated to take into account whether or not we have glCompressedTexSubImage2D

[robertphillips, 2014-07-30 19:49:00]

lgtm + typo

https://codereview.chromium.org/427093004/diff/60001/src/gpu/GrSWMaskHelper.h
File src/gpu/GrSWMaskHelper.h (right):

https://codereview.chromium.org/427093004/diff/60001/src/gpu/GrSWMaskHelper.h...
src/gpu/GrSWMaskHelper.h:109: // This is the desired format within which to
compress the
fComrpessMask ?

[krajcevski, 2014-07-30 19:56:13]

https://codereview.chromium.org/427093004/diff/60001/src/gpu/GrSWMaskHelper.h
File src/gpu/GrSWMaskHelper.h (right):

https://codereview.chromium.org/427093004/diff/60001/src/gpu/GrSWMaskHelper.h...
src/gpu/GrSWMaskHelper.h:109: // This is the desired format within which to
compress the
On 2014/07/30 19:49:00, robertphillips wrote:
> fComrpessMask ?

The frequency with which I make this mistake is astonishing.

[krajcevski, 2014-07-30 19:56:23]

The CQ bit was checked by krajcevski@google.com

[commit-bot: I haz the power, 2014-07-30 19:57:09]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/krajcevski@google.com/427093004/70004

[commit-bot: I haz the power, 2014-07-30 20:08:18]

Change committed as b3abe90145b988883c9882de1ac42da963adbf67