Start the process of choosing the correct compression format

src/gpu/GrSWMaskHelper.cpp

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrSWMaskHelper.h"
 
 #include "GrDrawState.h"
@@ skipping 32 matching lines @@
         kASTC_12x12_GrPixelConfig  // kASTC_12x12_Format,
     };
     GR_STATIC_ASSERT(0 == SkTextureCompressor::kLATC_Format);
     GR_STATIC_ASSERT(1 == SkTextureCompressor::kR11_EAC_Format);
     GR_STATIC_ASSERT(2 == SkTextureCompressor::kASTC_12x12_Format);
     GR_STATIC_ASSERT(SK_ARRAY_COUNT(configMap) == SkTextureCompressor::kFormatCnt);
 
     return configMap[fmt];
 }
 
+#if GR_COMPRESS_ALPHA_MASK

[robertphillips, 2014/07/30 12:15:49]

I would reverse the order of the arguments.
Would passing in the caps object make sense since it seems to be the least
powerful object required to get the job done?

[krajcevski, 2014/07/30 15:10:19]

Done.

+static bool choose_compressed_fmt(SkTextureCompressor::Format *fmt, GrContext *ctx) {
+    if (NULL == fmt) {
+        return false;
+    }
+
+    // Figure out what our preferred texture type is. If ASTC is available, that always
+    // gives the biggest win. Otherwise, in terms of compression speed and accuracy,
+    // LATC has a slight edge over R11 EAC.
+    bool result = false;
+    if (ctx->getGpu()->caps()->isConfigTexturable(kASTC_12x12_GrPixelConfig)) {
+        *fmt = SkTextureCompressor::kASTC_12x12_Format;
+        result = true;
+    } else if (ctx->getGpu()->caps()->isConfigTexturable(kLATC_GrPixelConfig)) {
+        *fmt = SkTextureCompressor::kLATC_Format;
+        result = true;
+    } else if (ctx->getGpu()->caps()->isConfigTexturable(kR11_EAC_GrPixelConfig)) {
+        *fmt = SkTextureCompressor::kR11_EAC_Format;
+        result = true;

[robertphillips, 2014/07/30 12:15:49]

We usually only use #error in preprocessor-ish code. How does this compile?

[krajcevski, 2014/07/30 15:10:19]

Done.

+        #error "FIXME: Is there a way to find out if we're on desktop or not?"
+    }
+
+    return result;
+}
+#endif
+
 }
 
 /**
  * Draw a single rect element of the clip stack into the accumulation bitmap
  */
 void GrSWMaskHelper::draw(const SkRect& rect, SkRegion::Op op,
                           bool antiAlias, uint8_t alpha) {
     SkPaint paint;
 
     SkXfermode* mode = SkXfermode::Create(op_to_mode(op));
@@ skipping 47 matching lines @@
         fMatrix.setIdentity();
     }
 
     // Now translate so the bound's UL corner is at the origin
     fMatrix.postTranslate(-resultBounds.fLeft * SK_Scalar1,
                           -resultBounds.fTop * SK_Scalar1);
     SkIRect bounds = SkIRect::MakeWH(resultBounds.width(),
                                      resultBounds.height());
 
 #if GR_COMPRESS_ALPHA_MASK
-    fCompressedFormat = SkTextureCompressor::kR11_EAC_Format;
+    fCompressMask = choose_compressed_fmt(&fCompressedFormat, fContext);
+#else
+    fCompressMask = false;
+#endif
 
     // Make sure that the width is a multiple of 16 so that we can use
     // specialized SIMD instructions that compress 4 blocks at a time.
-    int dimX, dimY;
-    SkTextureCompressor::GetBlockDimensions(fCompressedFormat, &dimX, &dimY);
-    const int cmpWidth = dimX * ((bounds.fRight + (dimX - 1)) / dimX);
-    const int cmpHeight = dimY * ((bounds.fBottom + (dimY - 1)) / dimY);
-#else
-    const int cmpWidth = bounds.fRight;
-    const int cmpHeight = bounds.fBottom;
-#endif
+    int cmpWidth, cmpHeight;
+    if (fCompressMask) {
+        int dimX, dimY;
+        SkTextureCompressor::GetBlockDimensions(fCompressedFormat, &dimX, &dimY);
+        cmpWidth = dimX * ((bounds.fRight + (dimX - 1)) / dimX);
+        cmpHeight = dimY * ((bounds.fBottom + (dimY - 1)) / dimY);
+    } else {
+        cmpWidth = bounds.fRight;
+        cmpHeight = bounds.fBottom;
+    }
 
     if (!fBM.allocPixels(SkImageInfo::MakeA8(cmpWidth, cmpHeight))) {
         return false;
     }
 
     sk_bzero(fBM.getPixels(), fBM.getSafeSize());
 
     sk_bzero(&fDraw, sizeof(fDraw));
     fRasterClip.setRect(bounds);
     fDraw.fRC    = &fRasterClip;
     fDraw.fClip  = &fRasterClip.bwRgn();
     fDraw.fMatrix = &fMatrix;
     fDraw.fBitmap = &fBM;
     return true;
 }
 
 /**
  * Get a texture (from the texture cache) of the correct size & format.
  * Return true on success; false on failure.
  */
 bool GrSWMaskHelper::getTexture(GrAutoScratchTexture* texture) {
     GrTextureDesc desc;
     desc.fWidth = fBM.width();
     desc.fHeight = fBM.height();
+    desc.fConfig = kAlpha_8_GrPixelConfig;
 
-#if GR_COMPRESS_ALPHA_MASK
+    if (fCompressMask) {
 
 #ifdef SK_DEBUG
-    int dimX, dimY;
-    SkTextureCompressor::GetBlockDimensions(fCompressedFormat, &dimX, &dimY);
-    SkASSERT((desc.fWidth % dimX) == 0);
-    SkASSERT((desc.fHeight % dimY) == 0);
+        int dimX, dimY;
+        SkTextureCompressor::GetBlockDimensions(fCompressedFormat, &dimX, &dimY);
+        SkASSERT((desc.fWidth % dimX) == 0);
+        SkASSERT((desc.fHeight % dimY) == 0);
 #endif
 
-    desc.fConfig = fmt_to_config(fCompressedFormat);
+        desc.fConfig = fmt_to_config(fCompressedFormat);
 
-    // If this config isn't supported then we should fall back to A8
-    if (!(fContext->getGpu()->caps()->isConfigTexturable(desc.fConfig))) {
-        desc.fConfig = kAlpha_8_GrPixelConfig;
+        // If this config isn't supported then we should fall back to A8
+        if (!(fContext->getGpu()->caps()->isConfigTexturable(desc.fConfig))) {
+            desc.fConfig = kAlpha_8_GrPixelConfig;
+        }
     }
-#else
-    desc.fConfig = kAlpha_8_GrPixelConfig;
-#endif
 
     texture->set(fContext, desc);
     return NULL != texture->texture();
 }
 
 void GrSWMaskHelper::sendTextureData(GrTexture *texture, const GrTextureDesc& desc,
                                      const void *data, int rowbytes) {
     // If we aren't reusing scratch textures we don't need to flush before
     // writing since no one else will be using 'texture'
     bool reuseScratch = fContext->getGpu()->caps()->reuseScratchTextures();
 
     // Since we're uploading to it, and it's compressed, 'texture' shouldn't
     // have a render target.
     SkASSERT(NULL == texture->asRenderTarget());
 
     texture->writePixels(0, 0, desc.fWidth, desc.fHeight,
                          desc.fConfig, data, rowbytes,
                          reuseScratch ? 0 : GrContext::kDontFlush_PixelOpsFlag);
 }
 
 void GrSWMaskHelper::compressTextureData(GrTexture *texture, const GrTextureDesc& desc) {
 
     SkASSERT(GrPixelConfigIsCompressed(desc.fConfig));
+    SkASSERT(fmt_to_config(fCompressedFormat) == desc.fConfig);
 
-    SkTextureCompressor::Format format = SkTextureCompressor::kLATC_Format;
-
-    // Choose the format required by the texture descriptor.
-    switch(desc.fConfig) {
-        case kLATC_GrPixelConfig:
-            format = SkTextureCompressor::kLATC_Format;
-            break;
-        case kR11_EAC_GrPixelConfig:
-            format = SkTextureCompressor::kR11_EAC_Format;
-            break;
-        default:
-            SkFAIL("Unrecognized texture compression format.");
-            break;
-    }
-
-    SkAutoDataUnref cmpData(SkTextureCompressor::CompressBitmapToFormat(fBM, format));
+    SkAutoDataUnref cmpData(SkTextureCompressor::CompressBitmapToFormat(fBM, fCompressedFormat));
     SkASSERT(NULL != cmpData);
 
     this->sendTextureData(texture, desc, cmpData->data(), 0);
 }
 
 /**
  * Move the result of the software mask generation back to the gpu
  */
 void GrSWMaskHelper::toTexture(GrTexture *texture) {
     SkAutoLockPixels alp(fBM);
 
     GrTextureDesc desc;
     desc.fWidth = fBM.width();
     desc.fHeight = fBM.height();
     desc.fConfig = texture->config();
         
     // First see if we should compress this texture before uploading.
-    if (GrPixelConfigIsCompressed(texture->config())) {
+    if (fCompressMask) {
         this->compressTextureData(texture, desc);
     } else {
         // Looks like we have to send a full A8 texture. 
         this->sendTextureData(texture, desc, fBM.getPixels(), fBM.rowBytes());
     }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 /**
  * Software rasterizes path to A8 mask (possibly using the context's matrix)
@@ skipping 50 matching lines @@
     maskMatrix.preConcat(drawState->getViewMatrix());
 
     drawState->addCoverageEffect(
                          GrSimpleTextureEffect::Create(texture,
                                                        maskMatrix,
                                                        GrTextureParams::kNone_FilterMode,
                                                        kPosition_GrCoordSet))->unref();
 
     target->drawSimpleRect(dstRect);
 }