Hide RenderBox::isBox() / RenderText::isText()

Hide RenderBox::isBox() / RenderText::isText()

Hide RenderBox::isBox() / RenderText::isText() to catch useless type checks
at compile time.

R=pdr@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179037

[pdr., 2014-07-27 20:55:24]

LGTM

https://codereview.chromium.org/425503002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBox.h (left):

https://codereview.chromium.org/425503002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBox.h:734: private:
I don't think you meant to remove "private".

https://codereview.chromium.org/425503002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderText.h (right):

https://codereview.chromium.org/425503002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderText.h:184: bool isText() const
WTF_DELETED_FUNCTION; // Hide to catch useless calls.
A small nit that should have been in my previous review: we may want to change
this to be a little clearer:
"This will catch anyone doing an unnecessary check."

My concern is that the current comment wouldn't be clear to me if I was just
scanning this file (hide... because it's private? or because it's deleted? oh..
maybe because we already have the correct type already?). I don't feel strongly
about the actual text used.

[Inactive, 2014-07-28 13:16:29]

https://codereview.chromium.org/425503002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderText.h (right):

https://codereview.chromium.org/425503002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderText.h:184: bool isText() const
WTF_DELETED_FUNCTION; // Hide to catch useless calls.
On 2014/07/27 20:55:23, pdr wrote:
> A small nit that should have been in my previous review: we may want to change
> this to be a little clearer:
> "This will catch anyone doing an unnecessary check."
> 
> My concern is that the current comment wouldn't be clear to me if I was just
> scanning this file (hide... because it's private? or because it's deleted?
oh..
> maybe because we already have the correct type already?). I don't feel
strongly
> about the actual text used.

Done. No worries, I will submit a clean up patch to fix the previous CL in dom/.

[Inactive, 2014-07-28 13:16:41]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-07-28 13:16:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/425503002/20001

[commit-bot: I haz the power, 2014-07-28 14:21:20]

Change committed as 179037