Hide RenderBox::isBox() / RenderText::isText()

Source/core/rendering/RenderText.h

 /*
  * (C) 1999 Lars Knoll (knoll@kde.org)
  * (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 163 matching lines @@
     virtual void layout() OVERRIDE FINAL { ASSERT_NOT_REACHED(); }
     virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation&, const LayoutPoint&, HitTestAction) OVERRIDE FINAL { ASSERT_NOT_REACHED(); return false; }
 
     void deleteTextBoxes();
     bool containsOnlyWhitespace(unsigned from, unsigned len) const;
     float widthFromCache(const Font&, int start, int len, float xPos, TextDirection, HashSet<const SimpleFontData*>* fallbackFonts, GlyphOverflow*) const;
     bool isAllASCII() const { return m_isAllASCII; }
 
     void secureText(UChar mask);
 
+    bool isText() const WTF_DELETED_FUNCTION; // Hide to catch useless calls.

[pdr., 2014/07/27 20:55:23]

A small nit that should have been in my previous review: we may want to change
this to be a little clearer:
"This will catch anyone doing an unnecessary check."

My concern is that the current comment wouldn't be clear to me if I was just
scanning this file (hide... because it's private? or because it's deleted? oh..
maybe because we already have the correct type already?). I don't feel strongly
about the actual text used.

[Inactive, 2014/07/28 13:16:29]

Done. No worries, I will submit a clean up patch to fix the previous CL in dom/.

+
     // We put the bitfield first to minimize padding on 64-bit.
     bool m_hasBreakableChar : 1; // Whether or not we can be broken into multiple lines.
     bool m_hasBreak : 1; // Whether or not we have a hard break (e.g., <pre> with '\n').
     bool m_hasTab : 1; // Whether or not we have a variable width tab character (e.g., <pre> with '\t').
     bool m_hasBreakableStart : 1;
     bool m_hasBreakableEnd : 1;
     bool m_hasEndWhiteSpace : 1;
     bool m_linesDirty : 1; // This bit indicates that the text run has already dirtied specific
                            // line boxes, and this hint will enable layoutInlineChildren to avoid
                            // just dirtying everything when character data is modified (e.g., appended/inserted
@@ skipping 34 matching lines @@
 inline void RenderText::checkConsistency() const
 {
 }
 #endif
 
 void applyTextTransform(const RenderStyle*, String&, UChar);
 
 } // namespace blink
 
 #endif // RenderText_h