Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 425293002: Rename "managed (mode|user)" to "supervised user" (part 9) (Closed)

Created:
6 years, 4 months ago by Marc Treib
Modified:
6 years, 4 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, pam+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename "managed (mode|user)" to "supervised user" (part 9) Followup to https://codereview.chromium.org/403343002/ This CL renames ChromeOS-specific resource IDs (strings/images) Still missing: - The global ENABLE_MANAGED_USERS define TBRing a bunch of renames. TBR=oshima@chromium.org (ash and c/b/ui/ash) TBR=antrim@chromium.org (c/b/chromeos and ui/login) BUG=385113 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287534

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -126 lines) Patch
M ash/ash_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ash/resources/ash_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/supervised/tray_supervised_user.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/user_card_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 1 chunk +52 lines, -52 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 6 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc View 5 chunks +40 lines, -40 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/login/display_manager.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Marc Treib
This might be the second to last! PTAL
6 years, 4 months ago (2014-07-31 08:35:10 UTC) #1
Pam (message me for reviews)
lgtm
6 years, 4 months ago (2014-08-04 21:24:37 UTC) #2
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 4 months ago (2014-08-05 08:25:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/425293002/20001
6 years, 4 months ago (2014-08-05 08:28:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 11:14:38 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 13:52:59 UTC) #6
Message was sent while issue was closed.
Change committed as 287534

Powered by Google App Engine
This is Rietveld 408576698