Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 425203002: Revert of Oilpan: Prepare to move RenderObject and RenderObjectChildList to Oilpan heap. (Closed)

Created:
6 years, 4 months ago by tkent
Modified:
6 years, 4 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, feature-media-reviews_chromium.org, blink-reviews-rendering, kouhei+svg_chromium.org, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, eric.carlson_apple.com, fs, blink-reviews-dom_chromium.org, dglazkov+blink, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rune+blink, Stephen Chennney, philipj_slow, rwlbuis
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: Prepare to move RenderObject and RenderObjectChildList to Oilpan heap. (https://codereview.chromium.org/423093002/) Reason for revert: It seems it caused a lot of crashes in Oilpan bots. Original issue's description: > Oilpan: Prepare to move RenderObject and RenderObjectChildList to Oilpan heap. > > We have a lot of remaining raw pointer members to RenderObject. Follow-up > patches will resolve them. > > BUG=398342 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179196 TBR=oilpan-reviews@chromium.org,zerny@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=398342 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179199

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -126 lines) Patch
M Source/core/dom/Node.h View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/NodeRareData.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/editing/TextIterator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextIterator.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M Source/core/rendering/RenderFrameSet.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderFrameSet.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderInline.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderMedia.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderMedia.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 6 chunks +8 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 5 chunks +4 lines, -15 lines 0 comments Download
M Source/core/rendering/RenderObjectChildList.h View 3 chunks +6 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderObjectChildList.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderTableCol.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTableCol.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderTableRow.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTableRow.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderTableSection.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGContainer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGContainer.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of Oilpan: Prepare to move RenderObject and RenderObjectChildList to Oilpan heap.
6 years, 4 months ago (2014-07-30 05:36:08 UTC) #1
haraken
LGTM to revert.
6 years, 4 months ago (2014-07-30 05:36:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/425203002/1
6 years, 4 months ago (2014-07-30 05:37:07 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 05:38:03 UTC) #4
Message was sent while issue was closed. 
Change committed as 179199

Powered by Google App Engine
This is Rietveld 408576698