Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: components/nacl/renderer/nexe_load_manager.cc

Issue 424893003: Pepper: Move NaCl fatal logging to Chrome IPC. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix for dmichael Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/renderer/nexe_load_manager.cc
diff --git a/components/nacl/renderer/nexe_load_manager.cc b/components/nacl/renderer/nexe_load_manager.cc
index adbc4c974286cefe51aba2ae01ad3f95bbcc4cfd..5e561aebd0b0333e835d8734b2a870b9b281a996 100644
--- a/components/nacl/renderer/nexe_load_manager.cc
+++ b/components/nacl/renderer/nexe_load_manager.cc
@@ -231,7 +231,7 @@ void NexeLoadManager::ReportLoadAbort() {
LogToConsole(error_string);
}
-void NexeLoadManager::NexeDidCrash(const char* crash_log) {
+void NexeLoadManager::NexeDidCrash() {
VLOG(1) << "Plugin::NexeDidCrash: crash event!";
// The NaCl module voluntarily exited. However, this is still a
// crash from the point of view of Pepper, since PPAPI plugins are
@@ -253,13 +253,6 @@ void NexeLoadManager::NexeDidCrash(const char* crash_log) {
"Nexe crashed during startup");
}
}
- // In all cases, try to grab the crash log. The first error
- // reported may have come from the start_module RPC reply indicating
- // a validation error or something similar, which wouldn't grab the
- // crash log. In the event that this is called twice, the second
- // invocation will just be a no-op, since the entire crash log will
- // have been received and we'll just get an EOF indication.
- CopyCrashLogToJsConsole(crash_log);
}
void NexeLoadManager::set_trusted_plugin_channel(
@@ -417,10 +410,4 @@ void NexeLoadManager::ReportDeadNexe() {
// to provide error handling.
}
-void NexeLoadManager::CopyCrashLogToJsConsole(const std::string& crash_log) {
- base::StringTokenizer t(crash_log, "\n");
- while (t.GetNext())
- LogToConsole(t.token());
-}
-
} // namespace nacl

Powered by Google App Engine
This is Rietveld 408576698