Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: components/nacl/renderer/nexe_load_manager.h

Issue 424893003: Pepper: Move NaCl fatal logging to Chrome IPC. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix for dmichael Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/renderer/nexe_load_manager.h
diff --git a/components/nacl/renderer/nexe_load_manager.h b/components/nacl/renderer/nexe_load_manager.h
index 9ecbe6710c80cd06b1785cdb05bf832c742ee636..06f30098c9fa8b6c7d7d154ddf31d2eb99129867 100644
--- a/components/nacl/renderer/nexe_load_manager.h
+++ b/components/nacl/renderer/nexe_load_manager.h
@@ -53,7 +53,7 @@ class NexeLoadManager {
const std::string& error_message,
const std::string& console_message);
void ReportLoadAbort();
- void NexeDidCrash(const char* crash_log);
+ void NexeDidCrash();
// TODO(dmichael): Everything below this comment should eventually be made
// private, when ppb_nacl_private_impl.cc is no longer using them directly.
@@ -117,9 +117,6 @@ class NexeLoadManager {
void ReportDeadNexe();
- // Copies a crash log to the console, one line at a time.
- void CopyCrashLogToJsConsole(const std::string& crash_log);
-
PP_Instance pp_instance_;
PP_NaClReadyState nacl_ready_state_;
bool nexe_error_reported_;

Powered by Google App Engine
This is Rietveld 408576698