Pepper: Move NaCl fatal logging to Chrome IPC.

components/nacl/renderer/nexe_load_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/nacl/renderer/nexe_load_manager.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_tokenizer.h"
@@ skipping 213 matching lines @@
   SetLastError(error_string);
 
   // Inform JavaScript that loading was aborted and is complete.
   DispatchProgressEvent(pp_instance_, ProgressEvent(PP_NACL_EVENT_ABORT));
   DispatchProgressEvent(pp_instance_, ProgressEvent(PP_NACL_EVENT_LOADEND));
 
   HistogramEnumerateLoadStatus(PP_NACL_ERROR_LOAD_ABORTED, is_installed_);
   LogToConsole(error_string);
 }
 
-void NexeLoadManager::NexeDidCrash(const char* crash_log) {
+void NexeLoadManager::NexeDidCrash() {
   VLOG(1) << "Plugin::NexeDidCrash: crash event!";
     // The NaCl module voluntarily exited.  However, this is still a
     // crash from the point of view of Pepper, since PPAPI plugins are
     // event handlers and should never exit.
   VLOG_IF(1, exit_status_ != -1)
       << "Plugin::NexeDidCrash: nexe exited with status " << exit_status_
       << " so this is a \"controlled crash\".";
   // If the crash occurs during load, we just want to report an error
   // that fits into our load progress event grammar.  If the crash
   // occurs after loaded/loadend, then we use ReportDeadNexe to send a
   // "crash" event.
   if (nexe_error_reported_) {
     VLOG(1) << "Plugin::NexeDidCrash: error already reported; suppressing";
   } else {
     if (nacl_ready_state_ == PP_NACL_READY_STATE_DONE) {
       ReportDeadNexe();
     } else {
       ReportLoadError(PP_NACL_ERROR_START_PROXY_CRASH,
                       "Nexe crashed during startup");
     }
   }
-  // In all cases, try to grab the crash log.  The first error
-  // reported may have come from the start_module RPC reply indicating
-  // a validation error or something similar, which wouldn't grab the
-  // crash log.  In the event that this is called twice, the second
-  // invocation will just be a no-op, since the entire crash log will
-  // have been received and we'll just get an EOF indication.
-  CopyCrashLogToJsConsole(crash_log);
 }
 
 void NexeLoadManager::set_trusted_plugin_channel(
     scoped_ptr<TrustedPluginChannel> channel) {
   trusted_plugin_channel_ = channel.Pass();
 }
 
 void NexeLoadManager::set_manifest_service_channel(
     scoped_ptr<ManifestServiceChannel> channel) {
   manifest_service_channel_ = channel.Pass();
@@ skipping 137 matching lines @@
     SetLastError(message);
     LogToConsole(message);
 
     DispatchProgressEvent(pp_instance_, ProgressEvent(PP_NACL_EVENT_CRASH));
     nexe_error_reported_ = true;
   }
   // else ReportLoadError() and ReportLoadAbort() will be used by loading code
   // to provide error handling.
 }
 
-void NexeLoadManager::CopyCrashLogToJsConsole(const std::string& crash_log) {
-  base::StringTokenizer t(crash_log, "\n");
-  while (t.GetNext())
-    LogToConsole(t.token());
-}
-
 }  // namespace nacl