Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 424813004: DevTools: Don't stop debugger inside V8 internal scripts with empty stack trace. (Closed)

Created:
6 years, 4 months ago by aandrey
Modified:
6 years, 4 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, blink-reviews-bindings_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Don't stop debugger inside V8 internal scripts with empty stack trace. R=yurys TEST=inspector/sources/debugger/debugger-autocontinue-on-syntax-error.html, inspector/sources/debugger/debugger-step-into-v8-internals.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -96 lines) Patch
M LayoutTests/http/tests/inspector/debugger-test.js View 1 chunk +45 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/debugger-step-into-v8-internals.html View 1 chunk +54 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/debugger-step-into-v8-internals-expected.txt View 1 chunk +20 lines, -0 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/frameworks-step-from-framework.html View 1 chunk +13 lines, -46 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/frameworks-steppings.html View 1 chunk +20 lines, -45 lines 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
aandrey
6 years, 4 months ago (2014-07-28 16:57:29 UTC) #1
yurys
lgtm
6 years, 4 months ago (2014-07-29 07:57:48 UTC) #2
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-07-29 08:57:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/424813004/1
6 years, 4 months ago (2014-07-29 08:58:55 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-29 10:09:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 10:49:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19428)
6 years, 4 months ago (2014-07-29 10:49:53 UTC) #7
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-07-29 11:18:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/424813004/1
6 years, 4 months ago (2014-07-29 11:18:23 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-29 11:54:20 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 12:34:29 UTC) #11
Message was sent while issue was closed.
Change committed as 179137

Powered by Google App Engine
This is Rietveld 408576698