Source/bindings/core/v8/ScriptDebugServer.cpp - Issue 424813004: DevTools: Don't stop debugger inside V8 internal scripts with empty stack trace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptDebugServer.cpp

Issue 424813004: DevTools: Don't stop debugger inside V8 internal scripts with empty stack trace. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/sources/debugger/frameworks-steppings.html ('k') | Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/ScriptDebugServer.cpp

diff --git a/Source/bindings/core/v8/ScriptDebugServer.cpp b/Source/bindings/core/v8/ScriptDebugServer.cpp

index a138051793f043bc9c302b753887aeb773e0e286..0aa99494ea405bc988179bea9e2ab697472294c9 100644

--- a/Source/bindings/core/v8/ScriptDebugServer.cpp

+++ b/Source/bindings/core/v8/ScriptDebugServer.cpp

@@ -492,10 +492,6 @@ void ScriptDebugServer::handleV8DebugEvent(const v8::Debug::EventDetails& eventD

v8::Handle<v8::Object> object = v8::Handle<v8::Object>::Cast(value);

dispatchDidParseSource(listener, object, event != v8::AfterCompile ? CompileError : CompileSuccess);

} else if (event == v8::Exception) {

- v8::Local<v8::StackTrace> stackTrace = v8::StackTrace::CurrentStackTrace(m_isolate, 1);

- // Stack trace is empty in case of syntax error. Silently continue execution in such cases.

- if (!stackTrace->GetFrameCount())

- return;

v8::Handle<v8::Object> eventData = eventDetails.GetEventData();

v8::Handle<v8::Value> exception = callInternalGetterFunction(eventData, "exception", m_isolate);

handleProgramBreak(ScriptState::from(eventContext), eventDetails.GetExecutionState(), exception, v8::Handle<v8::Array>());