Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 424813004: DevTools: Don't stop debugger inside V8 internal scripts with empty stack trace. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/core/v8/ScriptDebugServer.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Google Inc. All rights reserved. 3 * Copyright (C) 2013 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1279 matching lines...) Expand 10 before | Expand all | Expand 10 after
1290 breakpointObject->getString(DebuggerAgentState::condition, &breakpoint.c ondition); 1290 breakpointObject->getString(DebuggerAgentState::condition, &breakpoint.c ondition);
1291 RefPtr<TypeBuilder::Debugger::Location> location = resolveBreakpoint(it- >key, scriptId, breakpoint, UserBreakpointSource); 1291 RefPtr<TypeBuilder::Debugger::Location> location = resolveBreakpoint(it- >key, scriptId, breakpoint, UserBreakpointSource);
1292 if (location) 1292 if (location)
1293 m_frontend->breakpointResolved(it->key, location); 1293 m_frontend->breakpointResolved(it->key, location);
1294 } 1294 }
1295 } 1295 }
1296 1296
1297 ScriptDebugListener::SkipPauseRequest InspectorDebuggerAgent::didPause(ScriptSta te* scriptState, const ScriptValue& callFrames, const ScriptValue& exception, co nst Vector<String>& hitBreakpoints) 1297 ScriptDebugListener::SkipPauseRequest InspectorDebuggerAgent::didPause(ScriptSta te* scriptState, const ScriptValue& callFrames, const ScriptValue& exception, co nst Vector<String>& hitBreakpoints)
1298 { 1298 {
1299 ScriptDebugListener::SkipPauseRequest result; 1299 ScriptDebugListener::SkipPauseRequest result;
1300 if (m_javaScriptPauseScheduled) 1300 if (callFrames.isEmpty())
1301 result = ScriptDebugListener::Continue; // Skip pauses inside V8 interna l scripts and on syntax errors.
1302 else if (m_javaScriptPauseScheduled)
1301 result = ScriptDebugListener::NoSkip; // Don't skip explicit pause reque sts from front-end. 1303 result = ScriptDebugListener::NoSkip; // Don't skip explicit pause reque sts from front-end.
1302 else if (m_skipAllPauses) 1304 else if (m_skipAllPauses)
1303 result = ScriptDebugListener::Continue; 1305 result = ScriptDebugListener::Continue;
1304 else if (!hitBreakpoints.isEmpty()) 1306 else if (!hitBreakpoints.isEmpty())
1305 result = ScriptDebugListener::NoSkip; // Don't skip explicit breakpoints even if set in frameworks. 1307 result = ScriptDebugListener::NoSkip; // Don't skip explicit breakpoints even if set in frameworks.
1306 else if (!exception.isEmpty()) 1308 else if (!exception.isEmpty())
1307 result = shouldSkipExceptionPause(); 1309 result = shouldSkipExceptionPause();
1308 else if (m_debuggerStepScheduled || m_pausingOnNativeEvent) 1310 else if (m_debuggerStepScheduled || m_pausingOnNativeEvent)
1309 result = shouldSkipStepPause(); 1311 result = shouldSkipStepPause();
1310 else 1312 else
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
1436 1438
1437 void InspectorDebuggerAgent::trace(Visitor* visitor) 1439 void InspectorDebuggerAgent::trace(Visitor* visitor)
1438 { 1440 {
1439 visitor->trace(m_injectedScriptManager); 1441 visitor->trace(m_injectedScriptManager);
1440 visitor->trace(m_listener); 1442 visitor->trace(m_listener);
1441 InspectorBaseAgent::trace(visitor); 1443 InspectorBaseAgent::trace(visitor);
1442 } 1444 }
1443 1445
1444 } // namespace blink 1446 } // namespace blink
1445 1447
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/ScriptDebugServer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698