Source/core/svg/animation/SVGSMILElement.cpp - Issue 424733002: Simplify SVGAnimat\w+Element::parseAttribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 424733002: Simplify SVGAnimat\w+Element::parseAttribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Animation element should be inactive in SVGTest change Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/animation/SVGSMILElement.cpp

diff --git a/Source/core/svg/animation/SVGSMILElement.cpp b/Source/core/svg/animation/SVGSMILElement.cpp

index 903b246481fc94a26cfe1086e3ce0d76039b337b..1b491912267e520b5b13e8bb8bc9889ce1e38dba 100644

--- a/Source/core/svg/animation/SVGSMILElement.cpp

+++ b/Source/core/svg/animation/SVGSMILElement.cpp

@@ -542,8 +542,9 @@ void SVGSMILElement::parseAttribute(const QualifiedName& name, const AtomicStrin

setAttributeEventListener(EventTypeNames::endEvent, createAttributeEventListener(this, name, value, eventParameterName()));

} else if (name == SVGNames::onrepeatAttr) {

setAttributeEventListener(EventTypeNames::repeatEvent, createAttributeEventListener(this, name, value, eventParameterName()));

- } else

- SVGElement::parseAttribute(name, value);

+ } else {

+ SVGElement::parseAttributeNew(name, value);

+ }

}

void SVGSMILElement::svgAttributeChanged(const QualifiedName& attrName)