Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 424733002: Simplify SVGAnimat\w+Element::parseAttribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Animation element should be inactive in SVGTest change Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 } 535 }
536 parseBeginOrEnd(value.string(), End); 536 parseBeginOrEnd(value.string(), End);
537 if (inDocument()) 537 if (inDocument())
538 connectSyncBaseConditions(); 538 connectSyncBaseConditions();
539 } else if (name == SVGNames::onbeginAttr) { 539 } else if (name == SVGNames::onbeginAttr) {
540 setAttributeEventListener(EventTypeNames::beginEvent, createAttributeEve ntListener(this, name, value, eventParameterName())); 540 setAttributeEventListener(EventTypeNames::beginEvent, createAttributeEve ntListener(this, name, value, eventParameterName()));
541 } else if (name == SVGNames::onendAttr) { 541 } else if (name == SVGNames::onendAttr) {
542 setAttributeEventListener(EventTypeNames::endEvent, createAttributeEvent Listener(this, name, value, eventParameterName())); 542 setAttributeEventListener(EventTypeNames::endEvent, createAttributeEvent Listener(this, name, value, eventParameterName()));
543 } else if (name == SVGNames::onrepeatAttr) { 543 } else if (name == SVGNames::onrepeatAttr) {
544 setAttributeEventListener(EventTypeNames::repeatEvent, createAttributeEv entListener(this, name, value, eventParameterName())); 544 setAttributeEventListener(EventTypeNames::repeatEvent, createAttributeEv entListener(this, name, value, eventParameterName()));
545 } else 545 } else {
546 SVGElement::parseAttribute(name, value); 546 SVGElement::parseAttributeNew(name, value);
547 }
547 } 548 }
548 549
549 void SVGSMILElement::svgAttributeChanged(const QualifiedName& attrName) 550 void SVGSMILElement::svgAttributeChanged(const QualifiedName& attrName)
550 { 551 {
551 if (!isSupportedAttribute(attrName)) { 552 if (!isSupportedAttribute(attrName)) {
552 SVGElement::svgAttributeChanged(attrName); 553 SVGElement::svgAttributeChanged(attrName);
553 return; 554 return;
554 } 555 }
555 556
556 if (attrName == SVGNames::durAttr) 557 if (attrName == SVGNames::durAttr)
(...skipping 789 matching lines...) Expand 10 before | Expand all | Expand 10 after
1346 #if ENABLE(OILPAN) 1347 #if ENABLE(OILPAN)
1347 visitor->trace(m_targetElement); 1348 visitor->trace(m_targetElement);
1348 visitor->trace(m_timeContainer); 1349 visitor->trace(m_timeContainer);
1349 visitor->trace(m_conditions); 1350 visitor->trace(m_conditions);
1350 visitor->trace(m_syncBaseDependents); 1351 visitor->trace(m_syncBaseDependents);
1351 #endif 1352 #endif
1352 SVGElement::trace(visitor); 1353 SVGElement::trace(visitor);
1353 } 1354 }
1354 1355
1355 } 1356 }
OLDNEW
« Source/core/svg/SVGAnimationElement.cpp ('K') | « Source/core/svg/SVGAnimationElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698