Simplify SVGAnimat\w+Element::parseAttribute

Source/core/svg/SVGAnimationElement.cpp

Index: Source/core/svg/SVGAnimationElement.cpp
diff --git a/Source/core/svg/SVGAnimationElement.cpp b/Source/core/svg/SVGAnimationElement.cpp
index b1397f06b87b37edd66525151c86bfa0dd7b8145..3ae57ef42659a116516cafb9ded4fd53eb9f82bd 100644
--- a/Source/core/svg/SVGAnimationElement.cpp
+++ b/Source/core/svg/SVGAnimationElement.cpp
@@ -142,7 +142,6 @@ bool SVGAnimationElement::isSupportedAttribute(const QualifiedName& attrName)
 {
     DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
     if (supportedAttributes.isEmpty()) {
-        SVGTests::addSupportedAttributes(supportedAttributes);
         supportedAttributes.add(SVGNames::valuesAttr);
         supportedAttributes.add(SVGNames::keyTimesAttr);
         supportedAttributes.add(SVGNames::keyPointsAttr);
@@ -209,15 +208,12 @@ void SVGAnimationElement::parseAttribute(const QualifiedName& name, const Atomic
         return;
     }
 
-    if (SVGTests::parseAttribute(name, value))
-        return;

[kouhei (in TOK), 2014/07/28 13:34:41]

This is handled by SVGElement::parseAttributeNew

-
     ASSERT_NOT_REACHED();
 }
 
 void SVGAnimationElement::svgAttributeChanged(const QualifiedName& attrName)
 {
-    if (!isSupportedAttribute(attrName)) {
+    if (!isSupportedAttribute(attrName) && !SVGTests::isKnownAttribute(attrName)) {

[fs, 2014/07/28 14:01:01]

Nit: Maybe make a note that this (the SVGTests-call) should/will be moved back
to isSupportedAttribute - if that's the intention that is... maybe it isn't?

[kouhei (in TOK), 2014/07/28 14:28:58]

Hmm, I didn't intend to move it back later. Maybe I don't understand intention
of isSupportedAttribute() well.

For this particular CL, I guess the right fix is to derive SVGTests in
SVGSMILElement. In that way here is more natural, and SVGDiscardElement will get
SVGTests support too.

SVGDiscardElement should support SVGTests attributes but currently it doesn't.
https://svgwg.org/svg2-draft/single-page.html#struct-DiscardElement

[fs, 2014/07/28 17:12:36]

Moving it to SVGSMILElement SGTM (and would void this comment/confusion).

         SVGSMILElement::svgAttributeChanged(attrName);
         return;
     }