Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1592)

Unified Diff: mojo/services/view_manager/view_manager_service_impl.h

Issue 424533002: Cleans up usage of ViewManagerServiceImpl::roots_ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix attempt 2 Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/view_manager_service_impl.h
diff --git a/mojo/services/view_manager/view_manager_service_impl.h b/mojo/services/view_manager/view_manager_service_impl.h
index cf0c22915edf7dd7729623d074cb38c851de558d..4ea21a9d02abfb921b5c84f091db6b2432686e48 100644
--- a/mojo/services/view_manager/view_manager_service_impl.h
+++ b/mojo/services/view_manager/view_manager_service_impl.h
@@ -235,12 +235,12 @@ class MOJO_VIEW_MANAGER_EXPORT ViewManagerServiceImpl
// The set of nodes that has been communicated to the client.
NodeIdSet known_nodes_;
- // This is the set of nodes the connection can parent nodes to (in addition to
- // any nodes created by this connection). If empty the connection can
- // manipulate any nodes (except for deleting other connections nodes/views).
- // The connection can not delete or move these. If this is set to a non-empty
- // value and all the nodes are deleted (by another connection), then an
- // invalid node is added here to ensure this connection is still constrained.
+ // Set of root nodes from other connections. More specifically any time
+ // Embed() is invoked the id of the node is added to this set for the child
+ // connection. The connection Embed() was invoked on (the parent) doesn't
+ // directly track which connections are attached to which of its nodes. That
+ // information can be found by looking through the |roots_| of all
+ // connections.
NodeIdSet roots_;
// See description above setter.
« no previous file with comments | « mojo/services/view_manager/root_node_manager.cc ('k') | mojo/services/view_manager/view_manager_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698