Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: mojo/services/view_manager/view_manager_service_impl.h

Issue 424533002: Cleans up usage of ViewManagerServiceImpl::roots_ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix attempt 2 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_SERVICES_VIEW_MANAGER_VIEW_MANAGER_SERVICE_IMPL_H_ 5 #ifndef MOJO_SERVICES_VIEW_MANAGER_VIEW_MANAGER_SERVICE_IMPL_H_
6 #define MOJO_SERVICES_VIEW_MANAGER_VIEW_MANAGER_SERVICE_IMPL_H_ 6 #define MOJO_SERVICES_VIEW_MANAGER_VIEW_MANAGER_SERVICE_IMPL_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 scoped_ptr<AccessPolicy> access_policy_; 228 scoped_ptr<AccessPolicy> access_policy_;
229 229
230 // The nodes and views created by this connection. This connection owns these 230 // The nodes and views created by this connection. This connection owns these
231 // objects. 231 // objects.
232 NodeMap node_map_; 232 NodeMap node_map_;
233 ViewMap view_map_; 233 ViewMap view_map_;
234 234
235 // The set of nodes that has been communicated to the client. 235 // The set of nodes that has been communicated to the client.
236 NodeIdSet known_nodes_; 236 NodeIdSet known_nodes_;
237 237
238 // This is the set of nodes the connection can parent nodes to (in addition to 238 // Set of root nodes from other connections. More specifically any time
239 // any nodes created by this connection). If empty the connection can 239 // Embed() is invoked the id of the node is added to this set for the child
240 // manipulate any nodes (except for deleting other connections nodes/views). 240 // connection. The connection Embed() was invoked on (the parent) doesn't
241 // The connection can not delete or move these. If this is set to a non-empty 241 // directly track which connections are attached to which of its nodes. That
242 // value and all the nodes are deleted (by another connection), then an 242 // information can be found by looking through the |roots_| of all
243 // invalid node is added here to ensure this connection is still constrained. 243 // connections.
244 NodeIdSet roots_; 244 NodeIdSet roots_;
245 245
246 // See description above setter. 246 // See description above setter.
247 bool delete_on_connection_error_; 247 bool delete_on_connection_error_;
248 248
249 DISALLOW_COPY_AND_ASSIGN(ViewManagerServiceImpl); 249 DISALLOW_COPY_AND_ASSIGN(ViewManagerServiceImpl);
250 }; 250 };
251 251
252 #if defined(OS_WIN) 252 #if defined(OS_WIN)
253 #pragma warning(pop) 253 #pragma warning(pop)
254 #endif 254 #endif
255 255
256 } // namespace service 256 } // namespace service
257 } // namespace mojo 257 } // namespace mojo
258 258
259 #endif // MOJO_SERVICES_VIEW_MANAGER_VIEW_MANAGER_SERVICE_IMPL_H_ 259 #endif // MOJO_SERVICES_VIEW_MANAGER_VIEW_MANAGER_SERVICE_IMPL_H_
OLDNEW
« no previous file with comments | « mojo/services/view_manager/root_node_manager.cc ('k') | mojo/services/view_manager/view_manager_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698