mojo/services/view_manager/root_node_manager.cc - Issue 424533002: Cleans up usage of ViewManagerServiceImpl::roots_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/root_node_manager.cc

Issue 424533002: Cleans up usage of ViewManagerServiceImpl::roots_ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix attempt 2 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/view_manager/root_node_manager.cc

diff --git a/mojo/services/view_manager/root_node_manager.cc b/mojo/services/view_manager/root_node_manager.cc

index 17ad9b7b0b93171b5b28fc1689628d3b4747af72..1b286e610a1a1e09d9e2b63c490f2c28a9864e39 100644

--- a/mojo/services/view_manager/root_node_manager.cc

+++ b/mojo/services/view_manager/root_node_manager.cc

@@ -88,7 +88,7 @@ void RootNodeManager::RemoveConnection(ViewManagerServiceImpl* connection) {

void RootNodeManager::EmbedRoot(const std::string& url) {

if (connection_map_.empty()) {

- EmbedImpl(kRootConnection, String::From(url), InvalidNodeId());

+ EmbedImpl(kInvalidConnectionId, String::From(url), RootNodeId());

return;

}

ViewManagerServiceImpl* connection = GetConnection(kWindowManagerConnection);