Issue 423823005: Clarify comments for methods added in r178921

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 423823005: Clarify comments for methods added in r178921 (Closed)

Created:
6 years, 4 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
pdr.

CC:
blink-reviews, ed+blinkwatch_opera.com, blink-reviews-html_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, fs, blink-reviews-dom_chromium.org, dglazkov+blink, krit, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Clarify comments for methods added in r178921 Clarify comments for methods added in r178921 as per follow-up review comments. R=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179044

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -18 lines)			Patch
M	Source/core/dom/Attr.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/CharacterData.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/ContainerNode.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Document.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/DocumentFragment.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/Text.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/shadow/InsertionPoint.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLElement.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGElement.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/423823005/1

6 years, 4 months ago (2014-07-28 15:55:24 UTC) #4

Message was sent while issue was closed.

Change committed as 179044

Expand Messages | Collapse Messages