Source/core/dom/CharacterData.h - Issue 423823005: Clarify comments for methods added in r178921

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/dom/CharacterData.h

Issue 423823005: Clarify comments for methods added in r178921 (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/core/dom/Attr.h ('k') | Source/core/dom/ContainerNode.h » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserv ed.	4 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserv ed.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
69 String m_data;	69 String m_data;

70	70

71 private:	71 private:

72 virtual String nodeValue() const OVERRIDE FINAL;	72 virtual String nodeValue() const OVERRIDE FINAL;

73 virtual void setNodeValue(const String&) OVERRIDE FINAL;	73 virtual void setNodeValue(const String&) OVERRIDE FINAL;

74 virtual bool isCharacterDataNode() const OVERRIDE FINAL { return true; }	74 virtual bool isCharacterDataNode() const OVERRIDE FINAL { return true; }

75 virtual int maxCharacterOffset() const OVERRIDE FINAL;	75 virtual int maxCharacterOffset() const OVERRIDE FINAL;

76 virtual bool offsetInCharacters() const OVERRIDE FINAL;	76 virtual bool offsetInCharacters() const OVERRIDE FINAL;

77 void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, RecalcStyleBehavior = DoNotRecalcStyle);	77 void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, RecalcStyleBehavior = DoNotRecalcStyle);

78	78

79 bool isContainerNode() const WTF_DELETED_FUNCTION; // Hide to catch useless calls.	79 bool isContainerNode() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.

80 bool isElementNode() const WTF_DELETED_FUNCTION; // Hide to catch useless ca lls.	80 bool isElementNode() const WTF_DELETED_FUNCTION; // This will catch anyone d oing an unnecessary check.

81 };	81 };

82	82

83 DEFINE_NODE_TYPE_CASTS(CharacterData, isCharacterDataNode());	83 DEFINE_NODE_TYPE_CASTS(CharacterData, isCharacterDataNode());

84	84

85 } // namespace blink	85 } // namespace blink

86	86

87 #endif // CharacterData_h	87 #endif // CharacterData_h

OLD	NEW