Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: Source/core/svg/SVGElement.h

Issue 423823005: Clarify comments for methods added in r178921 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * Copyright (C) 2009, 2014 Apple Inc. All rights reserved. 4 * Copyright (C) 2009, 2014 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 // SVGFitToViewBox::parseAttribute uses reportAttributeParsingError. 227 // SVGFitToViewBox::parseAttribute uses reportAttributeParsingError.
228 friend class SVGFitToViewBox; 228 friend class SVGFitToViewBox;
229 void reportAttributeParsingError(SVGParsingError, const QualifiedName&, cons t AtomicString&); 229 void reportAttributeParsingError(SVGParsingError, const QualifiedName&, cons t AtomicString&);
230 bool hasFocusEventListeners() const; 230 bool hasFocusEventListeners() const;
231 231
232 private: 232 private:
233 // FIXME: Author shadows should be allowed 233 // FIXME: Author shadows should be allowed
234 // https://bugs.webkit.org/show_bug.cgi?id=77938 234 // https://bugs.webkit.org/show_bug.cgi?id=77938
235 virtual bool areAuthorShadowsAllowed() const OVERRIDE FINAL { return false; } 235 virtual bool areAuthorShadowsAllowed() const OVERRIDE FINAL { return false; }
236 236
237 bool isSVGElement() const WTF_DELETED_FUNCTION; // Hide to catch useless cal ls. 237 bool isSVGElement() const WTF_DELETED_FUNCTION; // This will catch anyone do ing an unnecessary check.
238 bool isStyledElement() const WTF_DELETED_FUNCTION; // Hide to catch useless calls. 238 bool isStyledElement() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.
239 239
240 RenderStyle* computedStyle(PseudoId = NOPSEUDO); 240 RenderStyle* computedStyle(PseudoId = NOPSEUDO);
241 virtual RenderStyle* virtualComputedStyle(PseudoId pseudoElementSpecifier = NOPSEUDO) OVERRIDE FINAL { return computedStyle(pseudoElementSpecifier); } 241 virtual RenderStyle* virtualComputedStyle(PseudoId pseudoElementSpecifier = NOPSEUDO) OVERRIDE FINAL { return computedStyle(pseudoElementSpecifier); }
242 virtual void willRecalcStyle(StyleRecalcChange) OVERRIDE; 242 virtual void willRecalcStyle(StyleRecalcChange) OVERRIDE;
243 243
244 void buildPendingResourcesIfNeeded(); 244 void buildPendingResourcesIfNeeded();
245 245
246 WillBeHeapHashSet<RawPtrWillBeWeakMember<SVGElement> > m_elementsWithRelativ eLengths; 246 WillBeHeapHashSet<RawPtrWillBeWeakMember<SVGElement> > m_elementsWithRelativ eLengths;
247 247
248 typedef HashMap<QualifiedName, RefPtr<SVGAnimatedPropertyBase> > AttributeTo PropertyMap; 248 typedef HashMap<QualifiedName, RefPtr<SVGAnimatedPropertyBase> > AttributeTo PropertyMap;
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 template<typename T> inline bool is##thisType(const PassRefPtr<T>& node) { r eturn is##thisType(node.get()); } \ 289 template<typename T> inline bool is##thisType(const PassRefPtr<T>& node) { r eturn is##thisType(node.get()); } \
290 template<typename T> inline bool is##thisType(const RefPtr<T>& node) { retur n is##thisType(node.get()); } \ 290 template<typename T> inline bool is##thisType(const RefPtr<T>& node) { retur n is##thisType(node.get()); } \
291 template <> inline bool isElementOfType<const thisType>(const SVGElement& el ement) { return is##thisType(element); } \ 291 template <> inline bool isElementOfType<const thisType>(const SVGElement& el ement) { return is##thisType(element); } \
292 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType) 292 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType)
293 293
294 } 294 }
295 295
296 #include "core/SVGElementTypeHelpers.h" 296 #include "core/SVGElementTypeHelpers.h"
297 297
298 #endif 298 #endif
OLDNEW
« no previous file with comments | « Source/core/html/HTMLElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698