Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 423303004: Change WokerThread to use a blink::WebThread (Closed)

Created:
6 years, 4 months ago by nasko
Modified:
6 years, 4 months ago
CC:
aandrey+blink_chromium.org, abarth-chromium, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, eustas+blink_chromium.org, falken, horo+watch_chromium.org, jamesr, kinuko+worker_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Change WokerThread to use a blink::WebThread This is a reland of https://codereview.chromium.org/400153002/ in which I forgot the remove the changes made to WebThread for shared timer. The first patch set is equivalent to the previous CL. BUG=301515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179217

Patch Set 1 #

Patch Set 2 : Remove changes made to WebThread. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -470 lines) Patch
M LayoutTests/SlowTests View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/WorkerScriptController.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/WorkerScriptDebugServer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/inspector/WorkerRuntimeAgent.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/workers/DedicatedWorkerThread.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/DedicatedWorkerThread.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/workers/WorkerRunLoop.h View 1 chunk +0 lines, -92 lines 0 comments Download
D Source/core/workers/WorkerRunLoop.cpp View 1 chunk +0 lines, -293 lines 0 comments Download
M Source/core/workers/WorkerThread.h View 3 chunks +37 lines, -19 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 11 chunks +205 lines, -45 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M Source/web/WebWorkerRunLoop.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M public/platform/Platform.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nasko
Hey Jochen, Can you review this CL? First patch is equivalent to the original CL ...
6 years, 4 months ago (2014-07-30 06:53:26 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-30 09:29:47 UTC) #2
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 4 months ago (2014-07-30 09:34:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/423303004/20001
6 years, 4 months ago (2014-07-30 09:34:58 UTC) #4
commit-bot: I haz the power
Change committed as 179217
6 years, 4 months ago (2014-07-30 09:38:31 UTC) #5
alancutter (OOO until 2018)
6 years, 4 months ago (2014-07-31 04:00:03 UTC) #6
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/432673003/ by alancutter@chromium.org.

The reason for reverting is: This change introduced leaks that were detected in
the following layout tests:
fast/workers/worker-terminate.html
({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,21]})
inspector-protocol/debugger/debugger-terminate-dedicated-worker-while-paused.html
({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,32]})

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/bu....

Powered by Google App Engine
This is Rietveld 408576698