Oilpan: Remove Element* raw pointers in objects

Oilpan: Remove Element* raw pointers in objects

- Make StyleResolver's StyleSharingList a HeapDeque of Member<Element>s.
- Make CSSFontFaceSrcValue::m_svgFontFaceElement a Member<Element>.
- Add a FIXME to make ScriptLoader::m_element to a Member<Element>.
Given that ResourceClient is going to be moved to the heap soon,
it would be better to just wait for it rather than making it a Persistent<Element>.

BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179086

[haraken, 2014-07-28 22:33:01]

PTAL

[tkent, 2014-07-28 23:31:58]

https://codereview.chromium.org/423013002/diff/1/Source/core/css/CSSFontFaceS...
File Source/core/css/CSSFontFaceSrcValue.h (right):

https://codereview.chromium.org/423013002/diff/1/Source/core/css/CSSFontFaceS...
Source/core/css/CSSFontFaceSrcValue.h:100:
RawPtrWillBeMember<SVGFontFaceElement> m_svgFontFaceElement;
This will leak a Document.
See https://codereview.chromium.org/333403004 and
https://codereview.chromium.org/337703004

[haraken, 2014-07-28 23:36:49]

On 2014/07/28 23:31:58, tkent wrote:
>
https://codereview.chromium.org/423013002/diff/1/Source/core/css/CSSFontFaceS...
> File Source/core/css/CSSFontFaceSrcValue.h (right):
> 
>
https://codereview.chromium.org/423013002/diff/1/Source/core/css/CSSFontFaceS...
> Source/core/css/CSSFontFaceSrcValue.h:100:
> RawPtrWillBeMember<SVGFontFaceElement> m_svgFontFaceElement;
> This will leak a Document.
> See https://codereview.chromium.org/333403004 and
> https://codereview.chromium.org/337703004

Thanks for pointing it out. I'll add a comment instead of making the change.

[haraken, 2014-07-29 00:25:48]

On 2014/07/28 23:36:49, haraken wrote:
> On 2014/07/28 23:31:58, tkent wrote:
> >
>
https://codereview.chromium.org/423013002/diff/1/Source/core/css/CSSFontFaceS...
> > File Source/core/css/CSSFontFaceSrcValue.h (right):
> > 
> >
>
https://codereview.chromium.org/423013002/diff/1/Source/core/css/CSSFontFaceS...
> > Source/core/css/CSSFontFaceSrcValue.h:100:
> > RawPtrWillBeMember<SVGFontFaceElement> m_svgFontFaceElement;
> > This will leak a Document.
> > See https://codereview.chromium.org/333403004 and
> > https://codereview.chromium.org/337703004
> 
> Thanks for pointing it out. I'll add a comment instead of making the change.

Since it was not easy to find a retaining path, I just dropped the change to
CSSFontFaceSrcValue in this CL.

[tkent, 2014-07-29 00:27:19]

lgtm

[commit-bot: I haz the power, 2014-07-29 00:28:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/423013002/20001

[haraken, 2014-07-29 00:35:19]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-07-29 00:36:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/423013002/40001

[commit-bot: I haz the power, 2014-07-29 02:30:16]

Change committed as 179086