Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 337703004: Revert of Oilpan: Trace CSSFontFaceSrcValue::m_svgFontFaceElement. (Closed)

Created:
6 years, 6 months ago by kouhei (in TOK)
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: Trace CSSFontFaceSrcValue::m_svgFontFaceElement. (https://codereview.chromium.org/333403004/) Reason for revert: This patch leaks svg-font-face-leak-document test http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=svg/svg-font-face-leak-document.html Original issue's description: > Oilpan: Trace CSSFontFaceSrcValue::m_svgFontFaceElement. > > BUG=357163 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176270 BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M Source/core/css/CSSFontFaceSrcValue.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kouhei (in TOK)
Created Revert of Oilpan: Trace CSSFontFaceSrcValue::m_svgFontFaceElement.
6 years, 6 months ago (2014-06-17 07:38:34 UTC) #1
kouhei (in TOK)
PTAL.
6 years, 6 months ago (2014-06-17 07:39:23 UTC) #2
Mads Ager (chromium)
LGTM, thanks Kouhei
6 years, 6 months ago (2014-06-17 07:45:39 UTC) #3
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 6 months ago (2014-06-17 07:45:56 UTC) #4
kouhei (in TOK)
On 2014/06/17 07:45:39, Mads Ager (chromium) wrote: > LGTM, thanks Kouhei I'll work on a ...
6 years, 6 months ago (2014-06-17 07:46:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/337703004/1
6 years, 6 months ago (2014-06-17 07:46:24 UTC) #6
tkent
lgtm. Thanks!
6 years, 6 months ago (2014-06-17 07:50:53 UTC) #7
haraken
LGTM
6 years, 6 months ago (2014-06-17 08:03:56 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 08:51:22 UTC) #9
Message was sent while issue was closed.
Change committed as 176299

Powered by Google App Engine
This is Rietveld 408576698